Patch 2006: clean up the patch name TAG and UNDO prefix mess for good - Darcs bug tracker

Title	clean up the patch name TAG and UNDO prefix mess for good
Superseder		Nosy List	bfrk
Related Issues
Status	in-discussion	Assigned To
Milestone

Created on 2020-02-28.21:20:16 by bfrk, last changed 2020-03-01.20:43:15 by ganesh.

Files
File name	Status	Uploaded	Type	Edit	Remove
clean-up-the-patch-name-tag-and-undo-prefix-mess-for-good.dpatch		bfrk, 2020-02-28.21:20:15	application/x-darcs-patch
introduce-empty.dpatch		ganesh, 2020-03-01.20:43:13	application/x-darcs-patch
patch-preview.txt		bfrk, 2020-02-28.21:20:15	text/x-darcs-patch
patch-preview.txt		ganesh, 2020-03-01.20:43:13	text/x-darcs-patch
unnamed		bfrk, 2020-02-28.21:20:15	text/plain
unnamed		ganesh, 2020-03-01.20:43:13	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg21953 (view)	Author: bfrk	Date: 2020-02-28.21:20:15
I am not yet screening this, sending so you can easily reproduce the shrinker problem. 1 patch for repository http://darcs.net/screened: patch 78297bfdb396eefe32e6b3ea603bd011c263ada0 Author: Ben Franksen <ben.franksen@online.de> Date: Fri Feb 28 17:13:09 CET 2020 * clean up the patch name TAG and UNDO prefix mess for good This rolls back most of patch 74e5d22381090db9e08f in favour of a safer and more principled solution. The way tags are distinguished from regular patches via a "TAG " prefix of the patch name is now fully hidden inside Darcs.Patch.Info and treated as an implementation detail. To facilitate this without too much disruption, we add a data type for patch names, forcing client code to be explicit about whether they create a tag or a regular patch. This uncovered a few bugs in the test suite where date and name were accidentally swapped. The "UNDO: " prefix that was traditionally prepended to the patch name for patches with the _piLegacyIsInverted flag is now treated more uniformly, so when such a patch gets amended without replacing the patch name, the prefix will be retained as part of the patch name. Attachments clean-up-the-patch-name-tag-and-undo-prefix-mess-for-good.dpatch patch-preview.txt unnamed
msg21954 (view)	Author: ganesh	Date: 2020-03-01.20:43:13
I think the loop in the shrinker may be introduced by your refactor, but I'm not certain. I'll go into more detail in the existing thread. 6 patches for repository darcs-unstable@darcs.net:screened: patch ce46362f2f1535553c0dc5ed8c7952236c275090 Author: Ganesh Sittampalam <ganesh@earth.li> Date: Sun Mar 1 17:38:13 GMT 2020 * introduce empty patch b8f51b8d185dc26ae1e4e7e546d13e3cf26fd358 Author: Ganesh Sittampalam <ganesh@earth.li> Date: Sun Mar 1 20:00:36 GMT 2020 * tests: bugfix for shrinking log lines The way we unpack the lines should be the inverse of the way rawPatchInfo packs them. patch ddea3326cdff03f59ba2e9c083e33f111902c181 Author: Ganesh Sittampalam <ganesh@earth.li> Date: Sun Mar 1 20:17:48 GMT 2020 * WIP: introduce shrinking tests patch 78297bfdb396eefe32e6b3ea603bd011c263ada0 Author: Ben Franksen <ben.franksen@online.de> Date: Fri Feb 28 16:13:09 GMT 2020 * clean up the patch name TAG and UNDO prefix mess for good This rolls back most of patch 74e5d22381090db9e08f in favour of a safer and more principled solution. The way tags are distinguished from regular patches via a "TAG " prefix of the patch name is now fully hidden inside Darcs.Patch.Info and treated as an implementation detail. To facilitate this without too much disruption, we add a data type for patch names, forcing client code to be explicit about whether they create a tag or a regular patch. This uncovered a few bugs in the test suite where date and name were accidentally swapped. The "UNDO: " prefix that was traditionally prepended to the patch name for patches with the _piLegacyIsInverted flag is now treated more uniformly, so when such a patch gets amended without replacing the patch name, the prefix will be retained as part of the patch name. patch 27932c82bb914b528ffd1c71e413d9e3d3b81dd5 Author: Ganesh Sittampalam <ganesh@earth.li> Date: Sun Mar 1 12:56:53 GMT 2020 * rollback metadata tests patch f7a6ff6f203bc6d1e01d73acf85f7094188efe64 Author: Ganesh Sittampalam <ganesh@earth.li> Date: Sun Mar 1 20:20:04 GMT 2020 * resolve conflicts Attachments introduce-empty.dpatch patch-preview.txt unnamed

History
Date	User	Action	Args
2020-02-28 21:20:16	bfrk	create
2020-03-01 20:43:05	ganesh	set	status: needs-screening -> in-discussion
2020-03-01 20:43:15	ganesh	set	files: + patch-preview.txt, introduce-empty.dpatch, unnamed messages: + msg21954