Patch 2046 Patch with test for failing issue #2648

Title Patch with test for failing issue #2648
Superseder Nosy List korobkov
Related Issues `darcs convert import` double-encodes cyrillic characters in UTF-8 input stream
View: 2648
Status accepted Assigned To

Created on 2020-07-13.22:50:28 by korobkov, last changed 2020-07-22.15:00:19 by bf.

File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2020-07-14.18:05:02 text/x-darcs-patch
test-for-failing-issue-_2648.dpatch korobkov, 2020-07-13.22:50:28 application/octet-stream
test-for-failing-issue-_2648.dpatch bf, 2020-07-14.18:05:02 application/x-darcs-patch
unnamed bf, 2020-07-14.18:05:02 text/plain
See mailing list archives for discussion on individual patches.
msg22152 (view) Author: bf Date: 2020-07-14.18:05:02
Thanks for the test!

Someone should have told you that tests scripts should refer to the
tests/data directory via the (predefined) $TESTDATA environment variable.
This is because tests are run via the test harness in a temporary directory.
I attached a patch to fix that.

2 patches for repository http://darcs.net/screened:

patch b3a4fdca1d1c8f653a8879f794c8673e1c24f6a3
Author: Andrey Korobkov <alster@vinterdalen.se>
Date:   Tue Jul 14 00:47:17 CEST 2020
  * Test for failing issue #2648
  `darcs convert import` double-encodes cyrillic characters in UTF-8 input stream

patch 12ed100c50bf3bf0ad0cb3d4f123d64722ce7553
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jul 14 20:11:04 CEST 2020
  * fix in test script: must use $TESTDATA to access test data
msg22154 (view) Author: bf Date: 2020-07-14.18:07:53
Pushed to screend (with the $TESTDATA fix).
msg22155 (view) Author: korobkov Date: 2020-07-14.18:09:50
Thank you for the explanation! :)
Date User Action Args
2020-07-13 22:50:28korobkovcreate
2020-07-14 18:05:03bfsetfiles: + patch-preview.txt, test-for-failing-issue-_2648.dpatch, unnamed
messages: + msg22152
2020-07-14 18:07:53bfsetstatus: needs-screening -> needs-review
messages: + msg22154
2020-07-14 18:09:50korobkovsetmessages: + msg22155
2020-07-22 15:00:19bfsetstatus: needs-review -> accepted