darcs

Patch 2048 fix in convert export: must quote file p... (and 2 more)

Title fix in convert export: must quote file p... (and 2 more)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2020-07-14.18:10:15 by bf, last changed 2020-07-27.07:36:16 by bf.

Files
File name Status Uploaded Type Edit Remove
fix-in-convert-export_-must-quote-file-paths-also-for-_d_-directive.dpatch bf, 2020-07-14.18:10:15 application/x-darcs-patch
fix-issue2648-test-on-windows.dpatch ganesh, 2020-07-25.23:38:16 application/x-darcs-patch
patch-preview.txt bf, 2020-07-14.18:10:15 text/x-darcs-patch
patch-preview.txt bf, 2020-07-23.11:14:30 text/x-darcs-patch
patch-preview.txt ganesh, 2020-07-25.23:38:16 text/x-darcs-patch
tests_convert_import_export_non_ascii_sh_-skip-test-on-windows.dpatch bf, 2020-07-23.11:14:30 application/x-darcs-patch
unnamed bf, 2020-07-14.18:10:15 text/plain
unnamed bf, 2020-07-23.11:14:30 text/plain
unnamed ganesh, 2020-07-25.23:38:16 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22156 (view) Author: bf Date: 2020-07-14.18:10:15
Here is the (hopefully) final fix for the import/export encoding issues,
plus an extended test with more funny characters in filenames.

3 patches for repository http://darcs.net/screened:

patch 4b0893101600925e131d2a3a52c3374f8246f63e
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jul 14 19:31:32 CEST 2020
  * fix in convert export: must quote file paths also for "D" directive

patch 86a147cd3b74052e0aeb7787aa5011daea0d7c2a
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jul 14 19:40:18 CEST 2020
  * add test for convert import/export with non-ASCII meta data and filenames

patch a457a8a68fc12fdd9075c69d6829a4050493ab53
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Jul 14 18:27:30 CEST 2020
  * resolve issue2648: convert import with non-ASCII meta data and filepaths
Attachments
msg22249 (view) Author: bf Date: 2020-07-23.11:14:30
1 patch for repository http://darcs.net/screened:

patch c18997bdcac696ae917f1299d01bc926d5d34046
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Jul 23 13:18:48 CEST 2020
  * tests/convert-import-export-non-ascii.sh: skip test on Windows
  
  See the comment in the script for why this test makes no sense on Windows.
Attachments
msg22254 (view) Author: ganesh Date: 2020-07-25.21:21:30
Code change looks reasonable to me. I think from the discussion about
windows tests on darcs-devel that we still need to figure out what's up
with the issue2648 test on Windows.
msg22259 (view) Author: ganesh Date: 2020-07-25.23:38:16
I figured out the Windows problem. Will self-accept with the
rest of this bundle as it's a test fix and trivial.

1 patch for repository darcs-unstable@darcs.net:screened:

patch 8fa10f60ebb9cd08f10f2c05580f624433403323
Author: Ganesh Sittampalam <ganesh@earth.li>
Date:   Sun Jul 26 00:44:17 BST 2020
  * fix issue2648 test on Windows
  
  We have to switch to a locale that can display the Cyrillic
  characters to be able to get them on stdout, even if that
  is a pipe.
Attachments
msg22265 (view) Author: bf Date: 2020-07-27.07:36:16
> I figured out the Windows problem.

Great!

>   We have to switch to a locale that can display the Cyrillic
>   characters to be able to get them on stdout, even if that
>   is a pipe.

Ah, yes, I suspected that might have been the problem.

Perhaps we should do that by default on startup? I mean, inside tests/lib?
History
Date User Action Args
2020-07-14 18:10:15bfcreate
2020-07-14 18:12:19bfsetstatus: needs-screening -> needs-review
2020-07-23 11:14:31bfsetfiles: + patch-preview.txt, tests_convert_import_export_non_ascii_sh_-skip-test-on-windows.dpatch, unnamed
messages: + msg22249
2020-07-25 21:21:30ganeshsetstatus: needs-review -> review-in-progress
messages: + msg22254
2020-07-25 21:21:40ganeshsetstatus: review-in-progress -> accepted-pending-tests
2020-07-25 23:38:16ganeshsetfiles: + patch-preview.txt, fix-issue2648-test-on-windows.dpatch, unnamed
messages: + msg22259
2020-07-25 23:42:23ganeshsetstatus: accepted-pending-tests -> accepted
2020-07-27 07:36:16bfsetmessages: + msg22265