Patch 2057: remove all MonadFail instances in darcs lib - Darcs bug tracker

Title	remove all MonadFail instances in darcs lib
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2020-07-19.14:33:26 by bfrk, last changed 2020-07-20.07:40:04 by ganesh.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		bfrk, 2020-07-19.14:33:25	text/x-darcs-patch
remove-all-monadfail-instances-in-darcs-lib.dpatch		bfrk, 2020-07-19.14:33:25	application/x-darcs-patch
unnamed		bfrk, 2020-07-19.14:33:25	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg22195 (view)	Author: bfrk	Date: 2020-07-19.14:33:25
Following up on review of patch2017. 1 patch for repository http://darcs.net/screened: patch 368451e02778df65951b7f8a024c2564e71426f7 Author: Ben Franksen <ben.franksen@online.de> Date: Sun Jul 19 16:35:54 CEST 2020 * remove all MonadFail instances in darcs lib The ones for the Perhaps type in the Prim.V1 and RepoPatchV1 implementations were not used. The one for hopefullyM was also unneeded, in fact it turns out that we only ever use it in the Maybe monad, so we change it to return Maybe, simplifying the implementation as well. Attachments patch-preview.txt remove-all-monadfail-instances-in-darcs-lib.dpatch unnamed
msg22208 (view)	Author: ganesh	Date: 2020-07-20.06:30:05
Nice cleanup, thanks. I had assumed the CPP was inevitable.

History
Date	User	Action	Args
2020-07-19 14:33:26	bfrk	create
2020-07-19 15:48:31	bfrk	set	status: needs-screening -> needs-review
2020-07-20 06:30:05	ganesh	set	status: needs-review -> accepted-pending-tests messages: + msg22208
2020-07-20 07:40:04	ganesh	set	status: accepted-pending-tests -> accepted