Following up on review of patch2037

Will screen if/when you confirm that the test succeeds on Windows, too.

1 patch for repository http://darcs.net/screened:

patch b483885aadc9d37df9cd0839aa06b3cd3eacf010
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Jul 20 12:16:33 CEST 2020
  * add tests for URL/path classification functions

Attachments

• add-tests-for-url_path-classification-functions.dpatch
• patch-preview.txt
• unnamed

Afraid they don't pass - see attached.

Attachments

• patch2062-output.txt

> Afraid they don't pass - see attached.

Hm. Indeed, the docs of System.FilePath.Windows.isValid claim that
colons in file paths are forbidden, except for specifying the "drive"
(volume).

Can you please check that this is correct i.e. Windows does not accept
paths with colons in them like those that fail the test?

If this is true, then the fix for issue2645 cannot work on Windows. This
calls the whole idea into question: if such a path is invalid on
Windows, then allowing them on a Posix system creates yet another
incompatibility when exchanging patches between repos residing on
different systems.

If this is not true, then we should report this as a bug against the
filepath library and create a work-around for it in darcs.

I did a bit of research and it appears that ':' is indeed not a valid
character in filenames on Windows.

> [...] then the fix for issue2645 cannot work on Windows. This
> calls the whole idea into question: if such a path is invalid on
> Windows, then allowing them on a Posix system creates yet another
> incompatibility when exchanging patches between repos residing on
> different systems.

Let me take this back, at least with regard the conclusion. This whole
thing is not about paths /inside/ a repo, but rather about paths /to/ a
repo. Besides, there are quite a lot more filename restrictions on
Windows, compared to Linux. There are even filenames consisting only of
alphabetic ASCII characters that are forbidden because they are reserved
for special things like IO ports.

My conclusion is that the text cases need to be fixed, while the patch
is fine.

Amended patch. The test should now succeed on Windows.

1 patch for repository http://darcs.net/screened:

patch a320b5d301ea39bb5b1deef816e904c1de7f3252
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Jul 20 12:16:33 CEST 2020
  * add tests for URL/path classification functions

Attachments

• add-tests-for-url_path-classification-functions.dpatch
• patch-preview.txt
• unnamed

Yep, all good now. I am most impressed with your remote Windows coding
skills :-)

self-accept