darcs

Patch 2068 resolve issue2275: ignore symlinks as re... (and 1 more)

Title resolve issue2275: ignore symlinks as re... (and 1 more)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2020-07-22.18:40:29 by bf, last changed 2020-07-25.22:13:10 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2020-07-22.18:40:26 text/x-darcs-patch
resolve-issue2275_-ignore-symlinks-as-repo-paths-even-when-the-index-is-used.dpatch bf, 2020-07-22.18:40:26 application/x-darcs-patch
unnamed bf, 2020-07-22.18:40:26 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22248 (view) Author: bf Date: 2020-07-22.18:40:26
This was easier to fix than I thought. Yet another issue resolved, yay!

2 patches for repository http://darcs.net/screened:

patch 1c4c3a92ab31d6ec0de642a520940161f4643760
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jul 22 19:56:33 CEST 2020
  * resolve issue2275: ignore symlinks as repo paths even when the index is used
  
  It was necessary to fix the last test scenario in the script (removing a
  recorded file and replacing it with a symbolic link to a non-existing file)
  because what the script expected here was not what we want, namely that the
  symbolic link is treated as if it wouldn't exist.

patch 5c9692acc334f683b7adf5487959a76b4c91ff7d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jul 22 20:43:09 CEST 2020
  * add a warning when the index code ignores a symlink
  
  The solution is unfortunately not perfect: some commands, notably
  'darcs wh -l' issue the warning twice per link. I think this is because of
  the implied '-s', since 'darcs wh -l --no-summary' displays it only once.
Attachments
msg22253 (view) Author: ganesh Date: 2020-07-25.21:09:51
The code change looks plausible. 

I haven't read through the issue2275 discussion and the new test code in
detail to make sure the two agree.
History
Date User Action Args
2020-07-22 18:40:29bfcreate
2020-07-22 19:00:32bfsetstatus: needs-screening -> needs-review
2020-07-25 21:09:52ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg22253
2020-07-25 22:13:10ganeshsetstatus: accepted-pending-tests -> accepted