darcs

Patch 2083 add (succeeding) test for issue2549

Title add (succeeding) test for issue2549
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2020-08-01.13:40:44 by bf, last changed 2020-10-17.08:10:12 by bf.

Files
File name Status Uploaded Type Edit Remove
add-_succeeding_-test-for-issue2549.dpatch bf, 2020-08-01.13:40:44 application/x-darcs-patch
patch-preview.txt bf, 2020-08-01.13:40:44 text/x-darcs-patch
unnamed bf, 2020-08-01.13:40:44 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22358 (view) Author: bf Date: 2020-08-01.13:40:44
We may still want to be stricter in what we accept when parsing a patch
bundle but that should be a separate issue.

1 patch for repository http://darcs.net/screened:

patch 3a1500fc006cb7d96fd5927091650e05356f8e49
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Aug  1 15:46:45 CEST 2020
  * add (succeeding) test for issue2549
Attachments
msg22420 (view) Author: ganesh Date: 2020-08-09.15:11:38
FYI the tests pass on Windows with this patch
msg22461 (view) Author: ganesh Date: 2020-10-16.19:05:04
If I understand correctly the rationale for the test is that darcs might
historically have written out patches with the trailing / so we want to
keep accepting them?
msg22472 (view) Author: bf Date: 2020-10-17.08:10:11
> If I understand correctly the rationale for the test is that darcs might
> historically have written out patches with the trailing / so we want to
> keep accepting them?

No. The test only demonstrates that the inconsistent behavior observed
in the bug report no longer exists. As I mentioned right at the top when
I posted the patch, my opinion is that we should *not* accept such a
bundle. But this is a separate issue.
History
Date User Action Args
2020-08-01 13:40:44bfcreate
2020-08-09 15:11:38ganeshsetmessages: + msg22420
2020-08-14 12:42:29bfsetstatus: needs-screening -> needs-review
2020-10-16 19:05:04ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg22461
2020-10-16 20:32:42ganeshsetstatus: accepted-pending-tests -> accepted
2020-10-17 08:10:12bfsetmessages: + msg22472