Patch 2086: add (succeeding) test for issue1956 - Darcs bug tracker

Title	add (succeeding) test for issue1956
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To	bfrk
Milestone

Created on 2020-08-02.00:04:42 by bfrk, last changed 2020-10-19.21:55:22 by ganesh.

Files
File name	Status	Uploaded	Type	Edit	Remove
add-_succeeding_-test-for-issue1956.dpatch		bfrk, 2020-08-02.00:04:42	application/x-darcs-patch
fix_-make-test-for-issue1956-succeed-and-no-longer-mark-as-failing.dpatch		bfrk, 2020-10-17.08:29:54	application/x-darcs-patch
patch-preview.txt		bfrk, 2020-08-02.00:04:42	text/x-darcs-patch
patch-preview.txt		bfrk, 2020-10-17.08:29:54	text/x-darcs-patch
unnamed		bfrk, 2020-08-02.00:04:42	text/plain
unnamed		bfrk, 2020-10-17.08:29:54	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg22374 (view)	Author: bfrk	Date: 2020-08-02.00:04:42
Amended to fix a typo. 1 patch for repository http://darcs.net/screened: patch fe2e433819a37d3722007a9f18ca6981379373dc Author: Ben Franksen <ben.franksen@online.de> Date: Sun Aug 2 01:50:35 CEST 2020 * add (succeeding) test for issue1956 Attachments add-_succeeding_-test-for-issue1956.dpatch patch-preview.txt unnamed
msg22422 (view)	Author: ganesh	Date: 2020-08-09.15:11:43
FYI the tests pass on Windows with this patch
msg22465 (view)	Author: ganesh	Date: 2020-10-16.19:24:27
why is it called failing- if it's supposed to be succeeding?
msg22473 (view)	Author: bfrk	Date: 2020-10-17.08:29:54
Sorry for the mess, I probably amended the patch but then sent an old version. The test failed as written, but that was just because we now always ask the user when we get conflicts with unrecorded changes. With that fixed the test actually succeeds as claimed. 1 patch for repository http://darcs.net/screened: patch 646cd1486dce233245ee872f000a59bc3c8c44bd Author: Ben Franksen <ben.franksen@online.de> Date: Sat Oct 17 10:34:52 CEST 2020 * fix: make test for issue1956 succeed and no longer mark as failing Attachments fix_-make-test-for-issue1956-succeed-and-no-longer-mark-as-failing.dpatch patch-preview.txt unnamed
msg22476 (view)	Author: bfrk	Date: 2020-10-17.09:01:25
> Sorry for the mess, I probably amended the patch but then sent an old[...] I have now pushed this fix to screened.

History
Date	User	Action	Args
2020-08-02 00:04:42	bfrk	create
2020-08-09 15:11:43	ganesh	set	messages: + msg22422
2020-08-14 12:41:21	bfrk	set	status: needs-screening -> needs-review
2020-10-16 19:24:27	ganesh	set	status: needs-review -> followup-requested assignedto: bfrk messages: + msg22465
2020-10-17 08:29:54	bfrk	set	files: + patch-preview.txt, fix_-make-test-for-issue1956-succeed-and-no-longer-mark-as-failing.dpatch, unnamed messages: + msg22473
2020-10-17 09:01:26	bfrk	set	messages: + msg22476
2020-10-19 20:22:22	ganesh	set	status: followup-requested -> accepted-pending-tests
2020-10-19 21:55:22	ganesh	set	status: accepted-pending-tests -> accepted