darcs

Patch 2094 relax upper bound for constraints to < 0.13 (and 3 more)

Title relax upper bound for constraints to < 0.13 (and 3 more)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2020-08-09.09:50:33 by bf, last changed 2020-08-09.15:13:24 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2020-08-09.09:50:29 text/x-darcs-patch
relax-upper-bound-for-constraints-to-_-0_13.dpatch bf, 2020-08-09.09:50:29 application/x-darcs-patch
unnamed bf, 2020-08-09.09:50:29 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22409 (view) Author: bf Date: 2020-08-09.09:50:29
For 2.16: cabal file maintenance

Building with -fwarn-as-error succeeds and the test suite passes for all
supported compilers (on Linux).

4 patches for repository http://darcs.net/screened:

patch 9cba0372c14aca1f85636002502c585c84335405
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug  9 11:15:42 CEST 2020
  * relax upper bound for constraints to < 0.13

patch 55a71d2bcac2b1771738c5462f86c215e24109d6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug  9 11:16:16 CEST 2020
  * relax upper bound for time to < 1.11

patch c2e38730ba7d6e6d4fe15101834c7dcceb3a2e79
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug  9 11:16:53 CEST 2020
  * relax upper bound for network-uri to < 2.8

patch 16a1d5612f2169997c0963c29c31553c70eb9887
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug  9 11:17:43 CEST 2020
  * relax upper bound for conduit to < 1.3.3
Attachments
msg22410 (view) Author: ganesh Date: 2020-08-09.10:10:28
All fine with me. I'll test on Windows with the higher bounds but I don't
think we need to be too paranoid.
msg22412 (view) Author: ganesh Date: 2020-08-09.10:52:53
Were you able to find an install plan with time>=1.10 with the tests 
enabled?
I get a conflict with test-framework, which only supports <1.10:

https://hackage.haskell.org/package/test-framework

When testing bounds changes I explicitly use `--constraint 'foo>=n'` where n
is just below the new upper bound.
msg22413 (view) Author: ganesh Date: 2020-08-09.11:07:14
Never mind, I'd forgotten about --allow-newer 'test-framework:time'.
msg22414 (view) Author: bf Date: 2020-08-09.12:23:37
> Were you able to find an install plan with time>=1.10 with the tests 
> enabled?

Yes, definitely. I ran the full test suite for all supported compilers.
I have

> cat cabal.project.local
flags: +warn-as-error
tests: True

> I'd forgotten about --allow-newer 'test-framework:time'.
I needed no such tweaks.

Which ghc version did you use?
msg22416 (view) Author: ganesh Date: 2020-08-09.12:58:20
>> I'd forgotten about --allow-newer 'test-framework:time'.
> I needed no such tweaks.
> 
> Which ghc version did you use?

I tried 8.6.5 and 8.10.1, but it shouldn't make any difference.

If you look at test-framework on hackage, it just don't support time>=1.10.
msg22417 (view) Author: bf Date: 2020-08-09.14:06:40
> If you look at test-framework on hackage, it just don't support time>=1.10.

Ah, now I understand what you are saying. It makes no difference in the
sense that whether we allow newer time versions or not, the current
version of test-framework will force us to use time < 1.10 anyway.

So we cannot currently test with time >= 1.10. Thus we should not raise
the upper bound.

I have obliterated the patch taht raises the upper bound for time in
screened and reviewed.
msg22423 (view) Author: ganesh Date: 2020-08-09.15:13:24
>> If you look at test-framework on hackage, it just don't support time>=1.10.
> 
> Ah, now I understand what you are saying. It makes no difference in the
> sense that whether we allow newer time versions or not, the current
> version of test-framework will force us to use time < 1.10 anyway.
> 
> So we cannot currently test with time >= 1.10. Thus we should not raise
> the upper bound.
> 
> I have obliterated the patch taht raises the upper bound for time in
> screened and reviewed.

Well, we can test, with --allow-newer (and I did). So we can be sure
that as soon as test-framework raises its upper bound, darcs will work.
I would have left the patch in.
History
Date User Action Args
2020-08-09 09:50:33bfcreate
2020-08-09 09:51:05bfsetstatus: needs-screening -> needs-review
2020-08-09 10:10:28ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg22410
2020-08-09 10:52:53ganeshsetmessages: + msg22412
2020-08-09 11:07:14ganeshsetmessages: + msg22413
2020-08-09 11:52:42ganeshsetstatus: accepted-pending-tests -> accepted
2020-08-09 12:23:37bfsetmessages: + msg22414
2020-08-09 12:58:20ganeshsetmessages: + msg22416
2020-08-09 14:06:41bfsetmessages: + msg22417
2020-08-09 15:13:24ganeshsetmessages: + msg22423