darcs

Patch 2095 Last changes for 2.16

Title Last changes for 2.16
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2020-08-13.16:57:14 by bf, last changed 2020-08-14.11:11:47 by bf.

Files
File name Status Uploaded Type Edit Remove
fix-in-release_sh.dpatch bf, 2020-08-13.16:57:11 application/octet-stream
fix-in-release_sh_0.dpatch bf, 2020-08-14.11:01:24 application/x-darcs-patch
patch-preview.txt bf, 2020-08-14.11:01:24 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg22427 (view) Author: bf Date: 2020-08-13.16:57:11
I had to fiddle with the release script, the Setup.hs, add a new small Haskell 
script to generate version info and fix a few missing files in the cabal file 
and do a bit of normalization in the test suite itself.

12 patches for repository http://darcs.net/screened:

patch 4f35f7ae9c9edd8497abbc02bb0d893a0d5b2916
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug  9 22:26:01 CEST 2020
  * fix in release.sh
  
  It seems with 2.16 we have to pass --enable-tests to cabal test to make it
  work.

patch 22ef0949af2554dd9918d69a197b76eef36042b6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 11:12:05 CEST 2020
  * fix in cabal file: add tests/network/httplib

patch a26c452b38a2f560d0ae50c3a16e8280d0a29566
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 11:26:38 CEST 2020
  * rename tests/data/*.tar.gz to *.tgz and use unpack_testdata consistently

patch d8c1699c1ddab312de1053432abfae62b422436c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 12:03:14 CEST 2020
  * add yet another missing item to extra-source-files

patch c2f9702c40bda118e10b9df8fbd5d90f20b84701
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 14:03:24 CEST 2020
  * release.sh: don't show test details, run 3 jobs in parallel

patch ce02613429a51837f0dfd58faa722e1615a75bd5
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 15:31:11 CEST 2020
  * allow use of release.sh with newer ghc versions

patch 597b16d56a015dc97f4568dd1ae6f808154afbf3
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Aug 11 13:08:06 CEST 2020
  * release.sh: also display the output of --exact-version

patch 28b9cd44697bfdd776d1b14f5c1090f72c181962
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 15:31:47 CEST 2020
  * replace buildHook, haddockHook, and replHook with postConf
  
  I found that the postConf step will be executed for all of cabal build,
  cabal haddock, and cabal repl. Though, contrary to what one would expect and
  what the docs say, not for cabal configure. Anyway, this simplifies our
  custom Setup.hs.

patch d13e28761a2f223463edd7feeb021f46cca53298
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 11:00:55 CEST 2020
  * add bundled shelly source files to our darcs.cabal
  
  This adds just the bare minimum required to build the test suite from the
  tar ball generated by cabal sdist.

patch 74e5f047194b84ca56ad8dc94d069afbf488cfb4
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Aug 11 12:57:45 CEST 2020
  * restore release/distributed-{version,context}
  
  However, instead of creating these files in Setup.hs, we now use a separate
  Haskell script. This is the recommended solution, see
  https://github.com/haskell/cabal/issues/6180. They are now again used in the
  postConf hook as a fallback when we cannot otherwise determine these values
  because we aren't in a darcs repo. This rolls back some of the changes made
  in
  
    patch 7a3388829209725128d0f9152746da7ac3c8ea88
    Author: Ben Franksen <ben.franksen@online.de>
    Date:   Sun Jan 26 20:56:37 CET 2020
      * remove sdist and postConf hooks from Setup.hs

patch 39dedbbf755aee3eb455f1b2db94e737532d0da1
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug  9 21:05:17 CEST 2020
  * again update the date for 2.16.1 in the CHANGELOG

patch 32554757b9941293b9573317d9ed5a61f4f1b993
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Aug 13 19:01:37 CEST 2020
  tagged 2.16.1
Attachments
msg22428 (view) Author: bf Date: 2020-08-13.16:58:56
Ganesh, could you take a look over these patches to see if I have 
missed anything obvious? I think we are ready to go for the release 
after these have been pushed.
msg22429 (view) Author: ganesh Date: 2020-08-13.20:38:45
They all look ok to me. I guess we need to discuss the long-term 
fate of distributed-{version,context} but what you've done looks fine
for now.
msg22430 (view) Author: bf Date: 2020-08-14.11:01:24
Same bundle with updated date in the CHANGELOG.

12 patches for repository http://darcs.net/screened:

patch 4f35f7ae9c9edd8497abbc02bb0d893a0d5b2916
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug  9 22:26:01 CEST 2020
  * fix in release.sh

  It seems with 2.16 we have to pass --enable-tests to cabal test to make it
  work.

patch 22ef0949af2554dd9918d69a197b76eef36042b6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 11:12:05 CEST 2020
  * fix in cabal file: add tests/network/httplib

patch a26c452b38a2f560d0ae50c3a16e8280d0a29566
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 11:26:38 CEST 2020
  * rename tests/data/*.tar.gz to *.tgz and use unpack_testdata consistently

patch d8c1699c1ddab312de1053432abfae62b422436c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 12:03:14 CEST 2020
  * add yet another missing item to extra-source-files

patch c2f9702c40bda118e10b9df8fbd5d90f20b84701
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 14:03:24 CEST 2020
  * release.sh: don't show test details, run 3 jobs in parallel

patch ce02613429a51837f0dfd58faa722e1615a75bd5
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 15:31:11 CEST 2020
  * allow use of release.sh with newer ghc versions

patch 597b16d56a015dc97f4568dd1ae6f808154afbf3
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Aug 11 13:08:06 CEST 2020
  * release.sh: also display the output of --exact-version

patch 28b9cd44697bfdd776d1b14f5c1090f72c181962
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 15:31:47 CEST 2020
  * replace buildHook, haddockHook, and replHook with postConf

  I found that the postConf step will be executed for all of cabal build,
  cabal haddock, and cabal repl. Though, contrary to what one would expect and
  what the docs say, not for cabal configure. Anyway, this simplifies our
  custom Setup.hs.

patch d13e28761a2f223463edd7feeb021f46cca53298
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 10 11:00:55 CEST 2020
  * add bundled shelly source files to our darcs.cabal

  This adds just the bare minimum required to build the test suite from the
  tar ball generated by cabal sdist.

patch 74e5f047194b84ca56ad8dc94d069afbf488cfb4
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Aug 11 12:57:45 CEST 2020
  * restore release/distributed-{version,context}

  However, instead of creating these files in Setup.hs, we now use a separate
  Haskell script. This is the recommended solution, see
  https://github.com/haskell/cabal/issues/6180. They are now again used in the
  postConf hook as a fallback when we cannot otherwise determine these values
  because we aren't in a darcs repo. This rolls back some of the changes made
  in

    patch 7a3388829209725128d0f9152746da7ac3c8ea88
    Author: Ben Franksen <ben.franksen@online.de>
    Date:   Sun Jan 26 20:56:37 CET 2020
      * remove sdist and postConf hooks from Setup.hs

patch e5f187385517274052787fb180a8c44179588b8b
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Aug  9 21:05:17 CEST 2020
  * again update the date for 2.16.1 in the CHANGELOG

patch d8d4673409290e071b5da5b600a3ea4515e1ee3b
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Aug 14 11:32:57 CEST 2020
  tagged 2.16.1


________________________________

Helmholtz-Zentrum Berlin für Materialien und Energie GmbH

Mitglied der Hermann von Helmholtz-Gemeinschaft Deutscher Forschungszentren e.V.

Aufsichtsrat: Vorsitzender Dr. Volkmar Dietz, stv. Vorsitzende Dr. Jutta Koch-Unterseher
Geschäftsführung: Prof. Dr. Bernd Rech (Sprecher), Prof. Dr. Jan Lüning, Thomas Frederking

Sitz Berlin, AG Charlottenburg, 89 HRB 5583

Postadresse:
Hahn-Meitner-Platz 1
D-14109 Berlin
Attachments
msg22431 (view) Author: bf Date: 2020-08-14.11:11:47
Self-accept after review.
History
Date User Action Args
2020-08-13 16:57:14bfcreate
2020-08-13 16:58:56bfsetmessages: + msg22428
2020-08-13 20:38:45ganeshsetmessages: + msg22429
2020-08-14 11:01:26bfsetfiles: + patch-preview.txt, fix-in-release_sh_0.dpatch
messages: + msg22430
2020-08-14 11:10:12bfsetstatus: needs-screening -> needs-review
2020-08-14 11:11:47bfsetstatus: needs-review -> accepted
messages: + msg22431