darcs

Patch 2098 adapt src/hscurl.hs to cabal-3.x (and 1 more)

Bug Tracker Home

Issues
Show Unassigned
 Show All
Search Issues

Patches
Show Open
 Show All
Search Patches

Login




Register
Lost your login?

Help
Roundup docs

Title adapt src/hscurl.hs to cabal-3.x (and 1 more)
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2020-08-24.05:50:55 by bfrk, last changed 2020-10-16.20:33:00 by ganesh.

Files
File name Status Uploaded Type Edit Remove
adapt-src_hscurl_hs-to-cabal_3_x.dpatch dead bfrk, 2020-08-24.05:50:54 application/x-darcs-patch
patch-preview.txt bfrk, 2020-08-24.05:50:54 text/x-darcs-patch
patch-preview.txt bfrk, 2020-08-24.06:11:49 text/x-darcs-patch
resolve-issue2655_-package_version-is-not-defined.dpatch bfrk, 2020-08-24.06:11:49 application/x-darcs-patch
unnamed bfrk, 2020-08-24.05:50:54 text/plain
unnamed bfrk, 2020-08-24.06:11:49 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22443 (view) Author: bfrk Date: 2020-08-24.05:50:54 
2 patches for repository http://darcs.net/screened:

patch 806ecb15cd287fdc573fcc39eb03fdef397e9a9e
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 24 07:35:26 CEST 2020
  * adapt src/hscurl.hs to cabal-3.x

patch 57fa8b90970bd5ca71d8d3cb293ed2d77d0ff14c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 24 07:55:49 CEST 2020
  * remove work-around for issue1824
  
  The underlying bug in ghc has been fixed a long time ago. Besides, the macro
  is no longer passed via command line but instead by including cabal_macros.h.
Attachments
msg22445 (view) Author: bfrk Date: 2020-08-24.06:11:49 
Amended patch description; I hadn't realized that we have an issue
associated with the bug report.

2 patches for repository http://darcs.net/screened:

patch 7ae9e49d92c88d4dcc94753ed2b5f478ac17a51e
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 24 07:35:26 CEST 2020
  * resolve issue2655: PACKAGE_VERSION is not defined
  
  This happens only if darcs is build with the -fcurl flag. The patch adapts
  src/hscurl.hs to use CURRENT_PACKAGE_VERSION and include the definition from
  "cabal_macros.h".

patch 1c0c6788eb538e7112a655a97901e61261af300d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Aug 24 07:55:49 CEST 2020
  * remove work-around for issue1824
  
  The underlying bug in ghc has been fixed a long time ago. Besides, the macro
  is no longer passed via command line but instead by including cabal_macros.h.
Attachments
msg22468 (view) Author: ganesh Date: 2020-10-16.19:31:55 
OK (though my personal inclination would still be to drop curl completely)
History
Date User Action Args
2020-08-24 05:50:55bfrkcreate
2020-08-24 06:11:49bfrksetfiles: + patch-preview.txt, resolve-issue2655_-package_version-is-not-defined.dpatch, unnamed
messages: + msg22445
2020-09-06 10:19:50bfrksetstatus: needs-screening -> needs-review
2020-10-16 19:31:55ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg22468
2020-10-16 20:33:00ganeshsetstatus: accepted-pending-tests -> accepted