Patch 2101 drop dependency on sandi and use base16-bytestring >= 1.0

Title drop dependency on sandi and use base16-bytestring >= 1.0
Superseder Nosy List bf
Related Issues
Status accepted Assigned To

Created on 2020-09-18.09:32:06 by bf, last changed 2020-10-16.21:39:17 by ganesh.

File name Status Uploaded Type Edit Remove
drop-dependency-on-sandi-and-use-base16_bytestring-__-1_0.dpatch bf, 2020-09-18.09:32:05 application/x-darcs-patch
patch-preview.txt bf, 2020-09-18.09:32:05 text/x-darcs-patch
unnamed bf, 2020-09-18.09:32:05 text/plain
See mailing list archives for discussion on individual patches.
msg22451 (view) Author: bf Date: 2020-09-18.09:32:05
I have tested this patch with a repo that contains quite a few binary files
(and patches), using 'time darcs check' on that repo. With this patch the
runtime consistently drops from about 16 seconds to about 12.5 seconds, a
25% improvement for very little effort. I propose to include this in

1 patch for repository http://darcs.net/screened:

patch 2f3c6267502d79c4762230b4282088d10c7386f7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Sep 18 11:03:00 CEST 2020
  * drop dependency on sandi and use base16-bytestring >= 1.0
  This was prompted by the announcement of base16-bytestring- which
  claims to give major performance improvements and a simpler API. As we use
  sandi only for base16 en/decoding and already depended on base16-bytestring
  in addition to that, this seemed like a logical step. It also turned out
  that the API of base16-bytestring fits our conventions better, in particular
  we can drop the separate pass that converts between upper and lower case,
  which should give us further performance improvement.
msg22462 (view) Author: ganesh Date: 2020-10-16.19:06:40
Looks good.
Date User Action Args
2020-09-18 09:32:06bfcreate
2020-10-16 14:53:53bfsetstatus: needs-screening -> needs-review
2020-10-16 19:06:41ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg22462
2020-10-16 21:39:17ganeshsetstatus: accepted-pending-tests -> accepted