darcs

Patch 211 Accept issue1232: darcs convert forgets ... (and 2 more)

Title Accept issue1232: darcs convert forgets ... (and 2 more)
Superseder Nosy List darcs-users, dino, kowey
Related Issues
Status accepted Assigned To
Milestone

Created on 2010-04-17.16:22:58 by dino, last changed 2011-05-10.19:05:41 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
accept-issue1232_-darcs-convert-forgets-_darcs_prefs_prefs.dpatch dino, 2010-04-17.16:22:58 text/x-darcs-patch
unnamed dino, 2010-04-17.16:22:58 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg10748 (view) Author: dino Date: 2010-04-17.16:22:58
3 patches for repository /home/dino/dev/darcs/branches/convert:

Sat Apr 17 11:45:30 EDT 2010  Dino Morelli <dino@ui3.info>
  * Accept issue1232: darcs convert forgets _darcs/prefs/prefs

Sat Apr 17 12:06:38 EDT 2010  Dino Morelli <dino@ui3.info>
  * Resolve issue1232: darcs convert forgets _darcs/prefs/prefs
  
  Added code to copy the _darcs/prefs/prefs file into the newly created
  darcs2 repository during a convert. A dumb copy is possibly not the best
  solution, but is better than nothing.

Sat Apr 17 12:19:29 EDT 2010  Dino Morelli <dino@ui3.info>
  * style tweak: reformatted an import
Attachments
msg10817 (view) Author: kowey Date: 2010-04-26.15:26:40
On Sat, Apr 17, 2010 at 16:22:59 +0000, Dino Morelli wrote:
> Sat Apr 17 11:45:30 EDT 2010  Dino Morelli <dino@ui3.info>
>   * Accept issue1232: darcs convert forgets _darcs/prefs/prefs
> 
> Sat Apr 17 12:06:38 EDT 2010  Dino Morelli <dino@ui3.info>
>   * Resolve issue1232: darcs convert forgets _darcs/prefs/prefs
>   
>   Added code to copy the _darcs/prefs/prefs file into the newly created
>   darcs2 repository during a convert. A dumb copy is possibly not the best
>   solution, but is better than nothing.
> 
> Sat Apr 17 12:19:29 EDT 2010  Dino Morelli <dino@ui3.info>
>   * style tweak: reformatted an import

Thanks for the amend! (and sorry for the late reply).

Resolve issue1232: darcs convert forgets _darcs/prefs/prefs
-----------------------------------------------------------
Yeah, see how much easier it is to understand what's going on in the
patch?

> +      -- Copy over the prefs file
> +      let prefsRelPath = darcsdir </> "prefs" </> "prefs"
> +      copyFileOrUrl [NoLinks] (repodir </> prefsRelPath)
> +         prefsRelPath Uncachable

Looks fine (as you say, we'll have to satisfice on this for now)

style tweak: reformatted an import
----------------------------------
> +import Darcs.Arguments
> +   ( DarcsFlag
> +      ( AllowConflicts, NewRepo, SetScriptsExecutable, UseFormat2
> +      , NoUpdateWorking, NoLinks
> +      )
> +   , reponame
> +   , setScriptsExecutableOption
> +   , networkOptions
> +   )

No particular objections one way or the other.

Generally speaking, I think darcs style should just aim to lend itself
to stability (no back-and-forth or dithering), simplicity (no asking
yourself what the policy is; should be self-evident or intuitive) and
minimal patches (changing something should not induce too many changes
to unrelated stuff).  The simplicity argument is why I've been
(semi-automatically) generating all these camel case patches.  It's to
eliminate people asking themselves what the difference between the
camelCase and the underscore functions are and which style they should
use.

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg10820 (view) Author: darcswatch Date: 2010-04-26.16:12:42
This patch bundle (with 3 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-c508e52f260adaf288fe37210c10361e8f083183
msg14139 (view) Author: darcswatch Date: 2011-05-10.19:05:41
This patch bundle (with 3 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-c508e52f260adaf288fe37210c10361e8f083183
History
Date User Action Args
2010-04-17 16:22:58dinocreate
2010-04-17 16:24:07darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-c508e52f260adaf288fe37210c10361e8f083183
2010-04-26 15:15:24koweylinkpatch210 superseder
2010-04-26 15:26:40koweysetstatus: needs-review -> accepted-pending-tests
nosy: + kowey
messages: + msg10817
2010-04-26 16:12:42darcswatchsetstatus: accepted-pending-tests -> accepted
messages: + msg10820
2011-05-10 19:05:41darcswatchsetmessages: + msg14139