darcs

Patch 2114 tests: some portability fixes for MacOS (and 1 more)

Title tests: some portability fixes for MacOS (and 1 more)
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2020-11-14.17:03:55 by bfrk, last changed 2020-12-19.21:44:22 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2020-11-14.17:03:55 text/x-darcs-patch
tests_-some-portability-fixes-for-macos.dpatch bfrk, 2020-11-14.17:03:55 application/x-darcs-patch
unnamed bfrk, 2020-11-14.17:03:55 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22509 (view) Author: bfrk Date: 2020-11-14.17:03:55
The are required to make the tests run successfully on MacOS.

2 patches for repository http://darcs.net/screened:

patch 6c65eef05bab8bfbf8d5f562284a0e866efdc0da
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Nov 14 11:46:32 CET 2020
  * tests: some portability fixes for MacOS
  
  Defaulting the directory argument of find to "." is is a GNUism and doesn't
  work on MacOS. Similarly, 'wc -l' on MacOS has spaces in its output, the new
  code is simpler and more portable. Also the test command in the MacOS bash
  apparently cannot handle the '!' operator.

patch 59fb0a73279b36da8ad5113835a74d7b74d6fe40
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Nov 14 07:59:31 CET 2020
  * remove the "compiled on <timestamp>" from exact version
  
  This information is not of much help and makes it impossible to create darcs
  binaries reproducably. It also causes problems when building in MacOS.
Attachments
msg22558 (view) Author: ganesh Date: 2020-12-19.20:25:45
Looks fine.
History
Date User Action Args
2020-11-14 17:03:55bfrkcreate
2020-11-14 17:04:24bfrksetstatus: needs-screening -> needs-review
2020-12-19 20:25:45ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg22558
2020-12-19 21:44:22ganeshsetstatus: accepted-pending-tests -> accepted