darcs

Patch 2122 resolve issue2668/part1 (and 2 more)

Title resolve issue2668/part1 (and 2 more)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2020-12-04.07:22:03 by bf, last changed 2020-12-19.22:29:29 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2020-12-04.07:22:03 text/x-darcs-patch
resolve-issue2668_part1_0.dpatch bf, 2020-12-04.07:22:03 application/x-darcs-patch
unnamed bf, 2020-12-04.07:22:03 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22537 (view) Author: bf Date: 2020-12-04.07:22:03
Updated bundle, sent using darcs after adapting the tls fingerprint in my
msmtp setup.

3 patches for repository http://darcs.net/screened:

patch 7ffb158bdd5282b0552f1c4bcd15a6a3f440cbb1
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Dec  4 07:12:40 CET 2020
  * resolve issue2668/part1
  
  This fixes the problem that causes storing the patch-index to fail if the
  parent of the repodir is read-only.

patch 460204b44fc8ff465276a719c1ec81630cff8c5b
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Dec  4 07:47:51 CET 2020
  * resolve issue2668: part2
  
  We have to catch IO errors when calling createOrUpdatePatchIndexDisk as this
  is not an essential failure and we are already past finalizing any other
  changes we made.

patch d10e837a6ebb301dd094dfd6f0aa2febde67d260
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Dec  4 07:13:00 CET 2020
  * add test for issue2668 (both parts)
Attachments
msg22562 (view) Author: ganesh Date: 2020-12-19.21:55:51
Looks good. I was worried that not updating the patch index could
leave it in an inconsistent state with respect to the respository, but
I see that the loading code (Darcs.Repository.PatchIndex.loadSafePatchIndex)
checks for that.
History
Date User Action Args
2020-12-04 07:22:03bfcreate
2020-12-18 09:02:20bfsetstatus: needs-screening -> needs-review
2020-12-19 21:55:51ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg22562
2020-12-19 22:29:29ganeshsetstatus: accepted-pending-tests -> accepted