darcs

Patch 2134 assorted mostly trivial cleanups

Title assorted mostly trivial cleanups
Superseder Nosy List bf
Related Issues
Status accepted-pending-tests Assigned To
Milestone

Created on 2020-12-20.11:54:09 by bf, last changed 2020-12-27.15:30:03 by bf.

Files
File name Status Uploaded Type Edit Remove
add-a-header-comment-to-tests_network_sshlib.dpatch bf, 2020-12-27.15:30:02 application/x-darcs-patch
add-more-thorough-checks-in-tests_oldfashioned_sh.dpatch bf, 2020-12-20.11:54:07 application/x-darcs-patch
patch-preview.txt bf, 2020-12-20.11:54:07 text/x-darcs-patch
patch-preview.txt bf, 2020-12-27.15:30:02 text/x-darcs-patch
unnamed bf, 2020-12-20.11:54:07 text/plain
unnamed bf, 2020-12-27.15:30:02 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22577 (view) Author: bf Date: 2020-12-20.11:54:07
I have pulled these from my working branch.

21 patches for repository http://darcs.net/screened:

patch 22657a32c96ad1b61f6d9b50de828d6a06b1d208
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Nov 11 07:15:52 CET 2020
  * add more thorough checks in tests/oldfashioned.sh

patch 8f16fdf7d2296a82dee2ea738746733f1a694ce0
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Oct 23 22:04:17 CEST 2020
  * use CommuteFn for genCommuteWhatWeCanRL and genCommuteWhatWeCanRL
  
  Also reformat their definition to make them more readable.

patch 881705a8d83c36190e6d4cae42e4daf5ffa3da80
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Oct 23 22:17:37 CEST 2020
  * use promptYorn instead of askUser in SelectChanges

patch 68031f4cf0989a48960a9c9fcb37d8ba45a71a15
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Oct 25 07:32:11 CET 2020
  * D.R.ApplyPatches: print warnings to stderr

patch 5566fcc6d7b01330b7a505b7f7ce69e6e5628f81
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Oct 25 07:35:42 CET 2020
  * fix typo in a comment

patch 9e2299b6df22db6e31d07e5def1fbef63dff1b59
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Oct 25 09:45:44 CET 2020
  * break and overlong type signature

patch c33cf2b2a3d529ed655de82f4d410fd076b87040
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Oct 25 19:09:46 CET 2020
  * fix comment in D.UI.Options.All

patch 0d83902770d4033f06833fa18152466210598eef
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Oct 29 15:01:01 CET 2020
  * amend: fix comment detail

patch 4914c9b3f53a2b2a119e1a767b9f318be7f56e2b
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Oct 30 11:09:48 CET 2020
  * remove re-export of repo flags from D.R.State

patch 81a6c8696117d7006e9e982da6e9a313e57524ad
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Oct 30 11:54:38 CET 2020
  * tests/issue1959-unwritable-darcsdir.sh: two more test cases

patch 68c8a26243ff5eadfcbd401ce067955dab73c636
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Nov  2 18:15:46 CET 2020
  * break an overlong code line in D.R.Hashed

patch d2197eb2d0bca00f936cc4af34ad2a19025833e9
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Nov  2 18:20:30 CET 2020
  * trivial fix in output of add command

patch 7efe968ea1c09f6cafdad714d877410f312e3b43
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Nov  2 18:20:56 CET 2020
  * make notInTreeParents local to addFiles

patch e9d69c788f43f0499294acdad675ba1a4908e0e0
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Nov  5 09:34:58 CET 2020
  * fix the compatibility docs for Suspended

patch 2072af04a687009c0a7d34f800cf6102f2978fc2
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Nov  5 09:52:34 CET 2020
  * remove a useless return ()

patch 78d45bfabdb159815694c520a31139ef0635e422
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Nov  5 10:39:51 CET 2020
  * minor cleanup in D.R.Pristine

patch cc33dc3a7f01b6fb9598a5d4e69be8617f2b2140
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Nov  8 15:05:34 CET 2020
  * in optimize command, simplify path to hashed pristine

patch d60c9dc310d6e995d2049cea35b3b347b18906aa
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Nov  9 18:09:22 CET 2020
  * issue a debugMessage when catchall catches an exception

patch 419f871910151658339443983a5087d435325ef8
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Nov 10 12:07:48 CET 2020
  * tests/network/sshlib: use a dir local to our test dir as REMOTE_DIR
  
  This avoids filling up /tmp and improves repeatability.

patch 6fe552b163fcc0b34316b5623257073d0b70ad91
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Nov 10 13:37:02 CET 2020
  * tests/EXAMPLE.sh: explain and follow best practices

patch f9f75c7730c06ac5e21df37866436148597549e6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Nov 10 13:40:18 CET 2020
  * make test for remote darcs log a bit faster
Attachments
msg22578 (view) Author: bf Date: 2020-12-20.11:58:51
BTW, this brings the number of patches I haven't yet sent down to 76.
msg22608 (view) Author: ganesh Date: 2020-12-26.16:03:30
>   * add more thorough checks in tests/oldfashioned.sh

OK

>   * use CommuteFn for genCommuteWhatWeCanRL and genCommuteWhatWeCanRL
>   
>   Also reformat their definition to make them more readable.

OK. The only non-formatting change is to replace a type with an alias.

>   * use promptYorn instead of askUser in SelectChanges
>   * D.R.ApplyPatches: print warnings to stderr
>   * fix typo in a comment
>   * break and overlong type signature
>   * fix comment in D.UI.Options.All
>   * amend: fix comment detail
>   * remove re-export of repo flags from D.R.State
>   * tests/issue1959-unwritable-darcsdir.sh: two more test cases
>   * break an overlong code line in D.R.Hashed
>   * trivial fix in output of add command
>   * make notInTreeParents local to addFiles
>   * fix the compatibility docs for Suspended
>   * remove a useless return ()
>   * minor cleanup in D.R.Pristine
>   * in optimize command, simplify path to hashed pristine

OK

>   * issue a debugMessage when catchall catches an exception

Good idea.


>   * tests/network/sshlib: use a dir local to our test dir as REMOTE_DIR
>   
>   This avoids filling up /tmp and improves repeatability.

OK, so this is safe because the ssh test always connects to
$(whoami)@localhost? It might be worth a comment on REMOTE_DIR that it
is really a local path, just being accessed via ssh.


>   * tests/EXAMPLE.sh: explain and follow best practices
>   * make test for remote darcs log a bit faster

OK
msg22611 (view) Author: bf Date: 2020-12-27.15:30:02
Documentation never hurts, so I added a few words of explanation to sshlib.
While I was at it, it occurred to me that there are a also some system level
requirements that must be met in order to run the ssh tests, so I have
mentioned these, too.

1 patch for repository http://darcs.net/screened:

patch 8f415685aa11cd99f3faca6335b2e44a2f578b17
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Dec 27 16:40:26 CET 2020
  * add a header comment to tests/network/sshlib
Attachments
History
Date User Action Args
2020-12-20 11:54:09bfcreate
2020-12-20 11:55:15bfsetstatus: needs-screening -> needs-review
2020-12-20 11:58:51bfsetmessages: + msg22578
2020-12-26 16:03:27ganeshsetstatus: needs-review -> accepted-pending-tests
2020-12-26 16:03:31ganeshsetmessages: + msg22608
2020-12-27 15:30:03bfsetfiles: + patch-preview.txt, add-a-header-comment-to-tests_network_sshlib.dpatch, unnamed
messages: + msg22611