darcs

Patch 2136 remove redundant call to siftForPending ... (and 8 more)

Title remove redundant call to siftForPending ... (and 8 more)
Superseder Nosy List bf
Related Issues
Status accepted Assigned To
Milestone

Created on 2020-12-20.15:40:52 by bf, last changed 2021-03-27.23:55:37 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2020-12-20.15:40:52 text/x-darcs-patch
patch-preview.txt bf, 2021-03-23.19:21:53 text/x-darcs-patch
remove-redundant-call-to-siftforpending-in-finalizepending.dpatch bf, 2020-12-20.15:40:52 application/x-darcs-patch
simplify-the-constraint-returned-by-checktree.dpatch bf, 2021-03-23.19:21:53 application/x-darcs-patch
unnamed bf, 2020-12-20.15:40:52 text/plain
unnamed bf, 2021-03-23.19:21:53 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22580 (view) Author: bf Date: 2020-12-20.15:40:52
Yet another bunch of assorted minor refactors pulled from my working branch.

9 patches for repository http://darcs.net/screened:

patch 9cd9b8bf17e06a88a995264b9f15bfd459d62819
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Oct 26 11:04:23 CET 2020
  * remove redundant call to siftForPending in finalizePending
  
  Sifting is done by makeNewPending anyway.

patch f984a3a8e355cf8c09d78f70732b8092edb1de8f
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Oct 26 20:05:32 CET 2020
  * Darcs.Util.Tree: implement overlay in applicative style
  
  I find this code now a lot easier to understand.

patch dc13d89285527e87dde5e664797ad3ecd5a8d8ee
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Oct 28 00:55:43 CET 2020
  * minor refactor in D.R.State.filteredWorking

patch df9b1e6a2384680dda7d6e67ba32241e5bc0c7f1
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Oct 30 09:01:02 CET 2020
  * add a few debug messages to D.R.State

patch d133dd869399f5fe5e4bb9bc36bee84b52414878
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Oct 31 11:53:00 CET 2020
  * throw out unneeded stuff from win32/System/Posix/IO.hsc

patch 22d0c7eb2e0487e33c009a6518d8359f86ae4218
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Nov  3 07:39:55 CET 2020
  * reformat overlong lines in D.T.Patch.Arbitrary.RepoPatchV2

patch 9061d6d7de14d94fca1cdbc16caebbfdeb07bcb9
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Nov  3 07:42:50 CET 2020
  * Darcs.Repository.Job: use Dict to pass dictionaries

patch 25fde72dfd7b2e10f70371873ea3a225c158f2da
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Nov  3 07:32:49 CET 2020
  * remove Darcs.Util.Printer.Color.debugDoc
  
  Using color in debug messages is bad. When you redirect stderr to a file it
  will be garbled with escape sequences; similar when piping to grep and so on.

patch 1f44aa4a1f1388817087f1ed88d9385fd8d6ac84
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Nov  5 08:53:30 CET 2020
  * improve haddocks for class PrimSift
Attachments
msg22660 (view) Author: ganesh Date: 2021-03-21.22:45:17
>   * remove redundant call to siftForPending in finalizePending

OK

>   * Darcs.Util.Tree: implement overlay in applicative style
>   
>   I find this code now a lot easier to understand.

That is indeed clearer.

>   * minor refactor in D.R.State.filteredWorking

OK

>   * add a few debug messages to D.R.State

OK


>   * throw out unneeded stuff from win32/System/Posix/IO.hsc

Excellent


>   * reformat overlong lines in D.T.Patch.Arbitrary.RepoPatchV2

OK

>   * Darcs.Repository.Job: use Dict to pass dictionaries

OK - the IsTree to Dict transition seems to use a slightly different
constraint, but if this all still typechecks then it must be fine :-)

>   * remove Darcs.Util.Printer.Color.debugDoc

OK

>   * improve haddocks for class PrimSift

OK
msg22664 (view) Author: bf Date: 2021-03-22.09:38:04
>>   * Darcs.Repository.Job: use Dict to pass dictionaries
> 
> OK - the IsTree to Dict transition seems to use a slightly different
> constraint, but if this all still typechecks then it must be fine :-)

I did not mean to change the constraint, else I would have added a note
in the patch log. Most probably a left-over from unrelated
experimentation that I failed to clean up. Will send a patch to revert
it back to the simpler original constraint.
msg22665 (view) Author: bf Date: 2021-03-22.13:36:37
> Will send a patch to revert it back to the simpler original constraint.

But not as a follow-up patch to this bundle because it depends on
intermediate changes.
msg22670 (view) Author: ganesh Date: 2021-03-22.20:55:20
> But not as a follow-up patch to this bundle because it depends on
> intermediate changes.

I have a feeling we discussed this before but I can't remember what the
conclusion was.

Thinking about it from scratch it's fine for me if bundles end up
"interleaved" because they can be marked as "accepted-pending-tests" and
then only finally pushed/closed once the intermediate bundle is applied.
But a separate bundle is also fine.
msg22676 (view) Author: bf Date: 2021-03-23.19:21:53
Following up on review. I was confused about possible dependencies, there
are none. So I am sending this to the same bundle as usual.

1 patch for repository http://darcs.net/screened:

patch c6300ed83c548a40fe13b610730fedde59e8755d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Mar 22 10:30:34 CET 2021
  * simplify the constraint returned by checkTree
  
  This reverts the result of checkTree to what it was before
  patch 9061d6d7de14d94fca1cdbc16caebbfdeb07bcb9
  Author: Ben Franksen <ben.franksen@online.de>
  Date:   Tue Nov  3 07:42:50 CET 2020
    * Darcs.Repository.Job: use Dict to pass dictionaries
  
  modulo the use of Dict instead of a custom type.
Attachments
msg22677 (view) Author: ganesh Date: 2021-03-23.19:28:05
Looks good.
History
Date User Action Args
2020-12-20 15:40:52bfcreate
2020-12-20 15:41:38bfsetstatus: needs-screening -> needs-review
2021-03-21 22:45:17ganeshsetmessages: + msg22660
2021-03-21 22:45:26ganeshsetstatus: needs-review -> accepted-pending-tests
2021-03-22 06:23:37ganeshsetstatus: accepted-pending-tests -> accepted
2021-03-22 09:38:05bfsetmessages: + msg22664
2021-03-22 13:36:37bfsetmessages: + msg22665
2021-03-22 20:55:21ganeshsetmessages: + msg22670
2021-03-23 19:21:54bfsetfiles: + patch-preview.txt, simplify-the-constraint-returned-by-checktree.dpatch, unnamed
messages: + msg22676
2021-03-23 19:28:05ganeshsetstatus: accepted -> accepted-pending-tests
messages: + msg22677
2021-03-27 23:55:37ganeshsetstatus: accepted-pending-tests -> accepted