darcs

Patch 2139 improve cache utilization

Title improve cache utilization
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2020-12-21.10:08:30 by bfrk, last changed 2021-03-27.23:55:53 by ganesh.

Files
File name Status Uploaded Type Edit Remove
fix_-rollback-erroneous-parts-of-_improve-cache-utilization_.dpatch bfrk, 2020-12-23.11:41:06 application/x-darcs-patch
patch-preview.txt bfrk, 2020-12-21.10:08:30 text/x-darcs-patch
patch-preview.txt bfrk, 2020-12-23.11:41:06 text/x-darcs-patch
rename-last-parameter-of-fetchfileusingcacheprivate.dpatch bfrk, 2020-12-21.10:08:30 application/x-darcs-patch
unnamed bfrk, 2020-12-21.10:08:30 text/plain
unnamed bfrk, 2020-12-23.11:41:06 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22583 (view) Author: bfrk Date: 2020-12-21.10:08:30
5 patches for repository http://darcs.net/screened:

patch bde509bab9567e36c5db5771284438ad4c575809
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Nov  9 14:07:16 CET 2020
  * rename last parameter of fetchFileUsingCachePrivate

patch 705541faa64186c2e6a746094de74983d4f9db50
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Nov  8 10:09:07 CET 2020
  * move Darcs.Repository.Cache to Darcs.Util.Cache
  
  The rationale for this move is that Darcs.Util.Tree.Hashed should be able to
  make use of caches which it previously could not.

patch a699b81c229204871619d5546848de8a5de00905
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Nov  8 10:19:52 CET 2020
  * clean up import lists in Darcs.Util.Cache

patch b215614cbc6ad59c81514da3403047d21f2fa0d6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Dec 21 11:09:30 CET 2020
  * minor cleanups in Darcs.Util.Cache (type signatures, debug messages, etc)

patch 018c5978374ec2cb3ae4f918d733da948bda73da
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Nov  9 15:47:50 CET 2020
  * improve cache utilization
  
  This adds additional (hard) links between cache locations:
  - create links not only in Directory caches, but in all Writable caches
  - add links when we write a hashed file (was marked as TODO in the sources)
  
  We have to add the --no-cache option in a few test scripts because darcs
  commands are now less likely to fail when we use the cache.
  
  The deeper reason behind this is that it will allow us to use the cache for
  all accesses to hashed pristine files.
Attachments
msg22599 (view) Author: bfrk Date: 2020-12-23.11:41:06
1 patch for repository http://darcs.net/screened:

patch 64ff303d25223945904121e73fb6d034a78cb794
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Dec 23 12:49:14 CET 2020
  * fix: rollback erroneous parts of "improve cache utilization"
  
  These changes don't have anything to do with what the patch claims to do
  (and otherwise indeed does). Furthermore, they can lead to unnecessary file
  download, which can make a cloning a local repo extremely slow.
Attachments
msg22663 (view) Author: ganesh Date: 2021-03-22.06:45:10
All OK (the bug tracker rejected my email review that just said that for
each patch, haven't seen that happen before)
History
Date User Action Args
2020-12-21 10:08:30bfrkcreate
2020-12-21 10:56:46bfrksetstatus: needs-screening -> needs-review
2020-12-23 11:41:07bfrksetfiles: + patch-preview.txt, fix_-rollback-erroneous-parts-of-_improve-cache-utilization_.dpatch, unnamed
messages: + msg22599
2021-03-22 06:44:05ganeshsetstatus: needs-review -> accepted-pending-tests
2021-03-22 06:45:10ganeshsetmessages: + msg22663
2021-03-27 23:55:53ganeshsetstatus: accepted-pending-tests -> accepted