Patch 2152 t/n/issue1932-remote.sh: loosen the chec... (and 1 more)

Title t/n/issue1932-remote.sh: loosen the chec... (and 1 more)
Superseder Nosy List gpiero
Related Issues
Status accepted Assigned To

Created on 2021-01-24.10:08:35 by gpiero, last changed 2021-02-21.10:22:09 by bf.

File name Status Uploaded Type Edit Remove
patch-preview.txt gpiero, 2021-01-24.10:08:33 text/x-darcs-patch
t_n_issue1932_remote_sh_-loosen-the-check-for-coping-with-different-ssh-versions.dpatch gpiero, 2021-01-24.10:08:33 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg22627 (view) Author: gpiero Date: 2021-01-24.10:08:33
The second patch is especially worth because of the change to the http test.
At the moment we are at the mercy of the fail.com registrant, as they could
trigger a fake test fail (best case) or even exploit a possible clone
vulnerability (worst case).

2 patches for repository http://darcs.net:

patch e2c58b31305f63eefa2c0e72c0039587a5897479
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Sun Jan 24 10:54:59 CET 2021
  * t/n/issue1932-remote.sh: loosen the check for coping with different ssh versions

patch a578431d6f3a813a1b3dfeaae2bf8d10ba5d1819
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Sun Jan 24 11:15:58 CET 2021
  * t/n/issue1932-remote.sh: use fake host names under example.org domain
msg22629 (view) Author: bf Date: 2021-01-24.11:09:43
-[ -n "$(grep 'ssh: Could not resolve hostname invalid' log)" ]
+fgrep 'ssh: Could not resolve host' log

Fine. However, would you mind replacing fgrep with grep -F or just 
plain grep? I think that is more portable.

-( http_proxy= darcs clone 
http://www.bogus.domain.so.it.will.surely.fail.com || true ) 2>&1 | tee 
+( http_proxy= darcs clone 
http://www.bogus.domain.so.it.will.surely.fail.example.org. || true ) 
>log 2>&1

I agree this is safer.
msg22633 (view) Author: bf Date: 2021-02-21.10:18:51
In the CI fgrep seems to work fine so I am screening this. Sorry for 
the delay.
msg22634 (view) Author: bf Date: 2021-02-21.10:22:09
Accepted, thanks!
Date User Action Args
2021-01-24 10:08:35gpierocreate
2021-01-24 11:09:43bfsetmessages: + msg22629
2021-02-21 10:18:52bfsetmessages: + msg22633
2021-02-21 10:19:48bfsetstatus: needs-screening -> needs-review
2021-02-21 10:22:09bfsetstatus: needs-review -> accepted
messages: + msg22634