darcs

Patch 2175 Cabal-Version: 2.2 -> 2.4

Title Cabal-Version: 2.2 -> 2.4
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2021-05-19.13:12:04 by bfrk, last changed 2021-05-26.07:44:32 by bfrk.

Files
File name Status Uploaded Type Edit Remove
cabal_version_-2_2-__-2_4.dpatch bfrk, 2021-05-19.13:12:04 application/x-darcs-patch
patch-preview.txt bfrk, 2021-05-19.13:12:04 text/x-darcs-patch
unnamed bfrk, 2021-05-19.13:12:04 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22789 (view) Author: bfrk Date: 2021-05-19.13:12:04
1 patch for repository http://darcs.net/screened:

patch 872a8c26404e56b0a31944c340e8c6a0254bd66a
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun May 16 14:19:52 CEST 2021
  * Cabal-Version: 2.2 -> 2.4
  
  This removes `cabal check` warnings caused by extra-source-files wildcards.
Attachments
msg22794 (view) Author: ganesh Date: 2021-05-19.20:26:30
fine
msg22806 (view) Author: ganesh Date: 2021-05-23.21:35:05
This appears to be breaking CI:
https://github.com/bfrk/darcs-ci/runs/2651426149

I'm rather confused as according to the docs, the Cabal-Version is synced
with the actual Cabal version:
https://cabal.readthedocs.io/en/3.4/file-format-changelog.html#package-
description-format-specification-history

There's a reference to
https://github.com/haskell/cabal/issues/4899
which I haven't digested properly yet.

Note this potentially affects the 2.16.4 release as well.
msg22808 (view) Author: bfrk Date: 2021-05-24.08:35:42
> This appears to be breaking CI:
> https://github.com/bfrk/darcs-ci/runs/2651426149

Yikes!

> I'm rather confused as according to the docs, the Cabal-Version is synced
> with the actual Cabal version:
> https://cabal.readthedocs.io/en/3.4/file-format-changelog.html#package-
> description-format-specification-history

Very strange: the problem exists only with ghc-8.4.4. How is that possible?

> There's a reference to
> https://github.com/haskell/cabal/issues/4899
> which I haven't digested properly yet.
> 
> Note this potentially affects the 2.16.4 release as well.

It does. Should I roll back and make a new release?
msg22810 (view) Author: ganesh Date: 2021-05-24.17:50:39
> Very strange: the problem exists only with ghc-8.4.4. How is that possible?

No idea. Also I am trying to reproduce it and haven't managed to yet: so
far I am trying GHC 8.4.4/Cabal 3.2.0.0 on NixOS (nixpkgs commit dd6ce8c).

>> Note this potentially affects the 2.16.4 release as well.
> 
> It does. Should I roll back and make a new release?

Let's wait a bit and try to characterise the problem first.
msg22811 (view) Author: ganesh Date: 2021-05-24.18:23:23
> No idea. Also I am trying to reproduce it and haven't managed to yet: so
> far I am trying GHC 8.4.4/Cabal 3.2.0.0 on NixOS (nixpkgs commit dd6ce8c).

I take that back: I can reproduce it with that environment. Turns out it
only failed after building dependencies.

I'll dig further now.
msg22813 (view) Author: ganesh Date: 2021-05-24.21:55:14
Found it, see patch2181.

I guess we ought to fix the 2.16 release too as it is likely to hit
anyone running GHC 8.4.
msg22820 (view) Author: bfrk Date: 2021-05-26.07:44:31
> Found it, see patch2181.

Thanks a lot for digging into this (and finding the proper solution)!

> I guess we ought to fix the 2.16 release too as it is likely to hit
> anyone running GHC 8.4.

Agreed. I would like to include the fix for issue2677 (not yet sent), in
the new release, while we're at it.
History
Date User Action Args
2021-05-19 13:12:04bfrkcreate
2021-05-19 13:13:02bfrksetstatus: needs-screening -> needs-review
2021-05-19 20:26:30ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg22794
2021-05-23 21:35:06ganeshsetstatus: accepted-pending-tests -> review-in-progress
messages: + msg22806
2021-05-24 08:35:44bfrksetmessages: + msg22808
2021-05-24 17:50:40ganeshsetmessages: + msg22810
2021-05-24 18:23:23ganeshsetmessages: + msg22811
2021-05-24 21:55:14ganeshsetmessages: + msg22813
2021-05-25 06:11:41ganeshsetstatus: review-in-progress -> accepted
2021-05-26 07:44:32bfrksetmessages: + msg22820