Please take a look before I screen, particularly the removal of the `darcs
send` warning.

1 patch for repository http://darcs.net/screened:

patch a31bfd7b2456df3b46192e948ebd404bc986755d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat May 22 16:05:02 CEST 2021
  * remove dependency on regex-compat-tdfa
  
  This copies a small number of trivial wrappers from that packages into a new
  module Darcs.Util.Regex. The only use of a non-trivial function was in the
  darcs send command where we decide if the system encoding is UTF-8
  compatible and warn the user if it is not. This part has been removed
  because non UTF-8 compatible system encodings are no longer relevant today.

Attachments

• patch-preview.txt
• remove-dependency-on-regex_compat_tdfa.dpatch
• unnamed

Looks fine to me, and it's nice to get rid of a bit more C from darcs.

I think our discussion on IRC was after you sent this and we didn't come
to a final conclusion on our strategy. Personally I'm fine with dropping
the dependency in whatever way seems best.

> I think our discussion on IRC was after you sent this and we didn't come
> to a final conclusion on our strategy.

Yes, I recorded this patch and then had second thoughts. One more data
point: the docs on subRegex and splitRegex (the two functions I did not
copy over to Darcs.Util.Regex) say

"This does not advance if the regex matches an empty string. This
misfeature is here to match the behavior of the original Text.Regex API."

I am not sure I want to maintain a package with such a compatibility
burden attached to it.

> Personally I'm fine with dropping
> the dependency in whatever way seems best.

I'll think about the options a bit more. In light of the above reasoning
I tend to think the way this patch does it may still be the best way.

screening

self-accept (after discussion on irc and elsewhere)