darcs

Patch 2179 replace catchNonExistence with ifDoesNot... (and 2 more)

Title replace catchNonExistence with ifDoesNot... (and 2 more)
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2021-05-23.13:25:50 by bfrk, last changed 2021-05-25.18:36:32 by bfrk.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2021-05-23.13:25:49 text/x-darcs-patch
replace-catchnonexistence-with-ifdoesnotexist.dpatch bfrk, 2021-05-23.13:25:49 application/x-darcs-patch
unnamed bfrk, 2021-05-23.13:25:49 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22801 (view) Author: bfrk Date: 2021-05-23.13:25:49
It may be more useful to review these patches in sum, rather than
separately. Squashing them is possible but only at the cost of rebasing all
of the other 108 unsent patches I have in my queue...

3 patches for repository http://darcs.net/screened:

patch f27e9996ab823991368b14450d23375c675293ef
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jan 20 12:35:20 CET 2021
  * replace catchNonExistence with ifDoesNotExist
  
  Apart from the order of arguments both are identical. I like the latter's
  argument order better because it is designed for prefix use, which removes
  uncertainty about precedence between do notation and operators.

patch 1e4b692d64b68737ff5cee475eb8b45e1ffa225a
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jan 20 12:45:18 CET 2021
  * in D.R.Rebase replace catchDoesNotExist with ifDoesNotExistError

patch 8891cb4c7f9ecfdf1aa5d355cfa7637418eee1d7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Feb 24 09:58:04 CET 2021
  * in D.R.Rebase replace catchIOError with catchDoesNotExistError
  
  It's always good to be more specific when handling exceptions.
Attachments
msg22804 (view) Author: ganesh Date: 2021-05-23.20:24:06
Looks fine, consider it reviewed (it's not in screened yet, not sure if
that's deliberate).
msg22818 (view) Author: bfrk Date: 2021-05-25.17:56:16
Pushed and marked as reviewed.
History
Date User Action Args
2021-05-23 13:25:50bfrkcreate
2021-05-23 20:24:07ganeshsetmessages: + msg22804
2021-05-25 17:56:16bfrksetstatus: needs-screening -> accepted-pending-tests
messages: + msg22818
2021-05-25 18:36:32bfrksetstatus: accepted-pending-tests -> accepted