Assorted minor patches here and there, mostly trivial, pulled from my
working branch.

10 patches for repository /home/ben/src/darcs/sent:

patch 98a2b63936d6b69c6881e694315bb109326d53c5
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Dec 27 21:39:25 CET 2020
  * remove debugMessage for withNamedTemp

patch 39e9eeb0ca42b945134373c9f74ecbf446c18f19
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Jan 22 16:19:35 CET 2021
  * rename diffOpts to diffOptions

patch 7362c28d2f27d92b5ba7b39ab21c23a50321835d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Mar  1 08:53:26 CET 2021
  * break an overlong line in the log command

patch fd0e1725e2269f13058a2981110b1799ffcfe295
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Mar  1 16:24:11 CET 2021
  * mark maybeIdentifyRepository and IdentifyRepo as exported for darcsden

patch 9e4fa0d86635c8bef5c37d6b869777173e8d9017
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Mar  1 21:22:42 CET 2021
  * push command: rename us' to only_us

patch c6e5b8bcc85a2b3313717e81dc824cea9214ff4d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Mar  1 23:42:03 CET 2021
  * layout fixes in amend command

patch e6c85b33e6f0a704b7ed6b0432b822a64837d2ca
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Mar  2 15:32:28 CET 2021
  * tentativelyRemovePatches_: clarify scope of pending

patch b7dbd3fcdd3f5435186fdac16bbf2fce6a8e6149
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Mar  2 22:35:11 CET 2021
  * amend: remove obsolete out-commented code

patch b3085efac7890ad585edbd6b016b502bdf0f25de
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar  3 22:06:38 CET 2021
  * remove some outdated TODO items from D.U.C.Rebase

patch c5475c9ad0da7773c899cfbd0121552ffd4e6b7e
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Apr 15 10:48:32 CEST 2021
  * use +<<+ instead of  +<+ reverseFL

Attachments

• patch-preview.txt
• remove-debugmessage-for-withnamedtemp.dpatch
• unnamed

Consider as reviewed.

>   * remove debugMessage for withNamedTemp

Fine though I'd favour just deleting rather than commenting out unwanted
things.

>   * rename diffOpts to diffOptions
>   * break an overlong line in the log command
>   * mark maybeIdentifyRepository and IdentifyRepo as exported for darcsden
>   * push command: rename us' to only_us
>   * layout fixes in amend command
>   * tentativelyRemovePatches_: clarify scope of pending


> patch b7dbd3fcdd3f5435186fdac16bbf2fce6a8e6149
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Tue Mar  2 22:35:11 CET 2021
>   * amend: remove obsolete out-commented code
> 
> patch b3085efac7890ad585edbd6b016b502bdf0f25de
> Author: Ben Franksen <ben.franksen@online.de>
> Date:   Wed Mar  3 22:06:38 CET 2021
>   * remove some outdated TODO items from D.U.C.Rebase

Fine

>   * use +<<+ instead of  +<+ reverseFL

Fine though I'm not actually sure this is an improvement, it doesn't
have a complexity advantage and is another operator to remember. But it
was there before and we could debate removing it and +>>+ entirely in a
separate patch.

>> * remove debugMessage for withNamedTemp
> 
> Fine though I'd favour just deleting rather than commenting out
> unwanted things.

In general I agree. Can we make an exception to this rule for code that
is only there for debugging? It makes it easier to restore the debug
code in case it will be needed again, and it is not a great problem if
such code has bit-rotted in the meantime.

>> * use +<<+ instead of  +<+ reverseFL
> 
> Fine though I'm not actually sure this is an improvement, it doesn't 
> have a complexity advantage and is another operator to remember.> But
> it was there before and we could debate removing it and +>>+ entirely
> in a separate patch.

I will respond to this in a separate message to the list then.

On 24/05/2021 06:43, Ben Franksen wrote:
> 
> Ben Franksen <ben.franksen@online.de> added the comment:
> 
>>> * remove debugMessage for withNamedTemp
>>
>> Fine though I'd favour just deleting rather than commenting out
>> unwanted things.
> 
> In general I agree. Can we make an exception to this rule for code that
> is only there for debugging? It makes it easier to restore the debug
> code in case it will be needed again, and it is not a great problem if
> such code has bit-rotted in the meantime.

Even for debug code I would favour either guarding it with "if False" /
"when False" or just removing it - any kind of commented out code feels
like noise to me. But it's not a big deal.