Patch 2190: remove UpdatePending parameter to withRe... (and 1 more) - Darcs bug tracker

Title	remove UpdatePending parameter to withRe... (and 1 more)
Superseder		Nosy List	bfrk
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2021-06-05.08:04:01 by bfrk, last changed 2021-06-08.05:25:58 by ganesh.

Files
File name	Status	Uploaded	Type	Edit	Remove
patch-preview.txt		bfrk, 2021-06-05.08:04:01	text/x-darcs-patch
remove-updatepending-parameter-to-withrepolock.dpatch		bfrk, 2021-06-05.08:04:01	application/x-darcs-patch
unnamed		bfrk, 2021-06-05.08:04:01	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg22850 (view)	Author: bfrk	Date: 2021-06-05.08:04:01
These two refactors aren't directly related, apart from being concerned with UpdatePending parameter. 2 patches for repository http://darcs.net/screened: patch a23e1eab6822d362d991a8da5370b0ab2e43fc93 Author: Ben Franksen <ben.franksen@online.de> Date: Fri Jan 22 18:33:46 CET 2021 * remove UpdatePending parameter to withRepoLock It turned out that we always call that procedure with YesUpdatePending, so we can as well hard-code it. patch 4f9ac2caf52b420538798dddc15f4211c1fdcaa8 Author: Ben Franksen <ben.franksen@online.de> Date: Tue Mar 2 14:13:40 CET 2021 * obliterate, rebase suspend: pass NoUpdatePending to tentativelyRemovePatches This avoids the redundant use of the (unsafe) tentativelyAddToPending to remove what gets added to pending with YesUpdatePending. Attachments patch-preview.txt remove-updatepending-parameter-to-withrepolock.dpatch unnamed
msg22852 (view)	Author: ganesh	Date: 2021-06-05.09:10:26
Both look good.

History
Date	User	Action	Args
2021-06-05 08:04:01	bfrk	create
2021-06-05 09:10:27	ganesh	set	status: needs-screening -> accepted-pending-tests messages: + msg22852
2021-06-08 05:25:58	ganesh	set	status: accepted-pending-tests -> accepted