8 patches for repository http://darcs.net/screened:

patch b752ceb6469f5f49b4d7f3c033f3c0dcd64b799a
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar 24 08:25:32 CET 2021
  * remove overspecification of pending from tests
  
  The test scripts should not prescribe the concrete format of the pending
  patch, not even an empty one.

patch b00d8d3eaf14ebc2127acaf95f5f036797e4e172
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Feb 25 13:07:23 CET 2021
  * harness: remove the hashed testsuite from --full
  
  This test suite cannot be trun in parallel and --full just takes too long
  without that.

patch 4ae1e19fd0b4a8d49ba31481caef710ce41e132c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar  3 12:02:26 CET 2021
  * harness: run test-framework with explicit RunnerOptions

patch c7f52e5cd185671c1022e9751a1e87ddc21b75ef
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu May 27 18:19:20 CEST 2021
  * tests: mark issue1014 as no longer failing
  
  After fixing a few minor issues in the test script, this test succeeds for
  darcs-3 as that fixes the underlying issue. However, the test script needed
  a few minor fixes to actually fail for the right reason. In particular,
  cloning a conflicted repo nowadays applies conflict markup, which we have to
  revert before pulling, otherwise we get prompted and the test fails with
  "promptChar: unexpected end of input".

patch bf1b80bc76857f40190c4543cdc326cc0cfa7193
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu May 27 18:40:14 CEST 2021
  * test for issue1579 no longer fails

patch b455a3beca721076c9e20b6c328f9a30c4293f9e
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu May 27 18:52:30 CEST 2021
  * tests for issue1327 and issue2047 fail only for darcs-1 and darcs-2

patch 2f823d1b183f41f1602d79e56aebb1727744fe04
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu May 27 18:53:33 CEST 2021
  * test for issue1461 is no longer failing

patch 6ca7649c6dfc443237c26a8747a567bb45875111
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat May 29 17:39:06 CEST 2021
  * tests/network/show_tags-remote.sh: remove directories

Attachments

• patch-preview.txt
• remove-overspecification-of-pending-from-tests.dpatch
• unnamed

> harness: remove the hashed testsuite from --full

I appreciate the motivation but it could be a bit surprising to discover
that there are tests not included in something called "full".

Maybe we should have a "standard" instead and keep everything in "full"?

The rest of the patches look fine, consider them reviewed (they're not 
screened yet).

>> harness: remove the hashed testsuite from --full
> 
> I appreciate the motivation but it could be a bit surprising to discover
> that there are tests not included in something called "full".
> 
> Maybe we should have a "standard" instead and keep everything in "full"?

I guess for the moment I'll keep this patch only in my own clones,
removing it from the bundle.

> The rest of the patches look fine, consider them reviewed (they're not 
> screened yet).

And well I did not push them because the test for issue1461 indeed fails
on Windows and MacOS, so I'll remove this one from the bundle, too.

>>> harness: remove the hashed testsuite from --full
>>
>> I appreciate the motivation but it could be a bit surprising to discover
>> that there are tests not included in something called "full".
>>
>> Maybe we should have a "standard" instead and keep everything in "full"?
> 
> I guess for the moment I'll keep this patch only in my own clones,
> removing it from the bundle.

I don't want to make your life harder unnecessarily so if you still
prefer to have this change after considering my comment, I'm ok with it
being applied centrally. I know from experience that it's a pain and
source of possible accidents to be maintaining changes locally only.

Same bundle with two bad/questionable patches removed.

6 patches for repository http://darcs.net/screened:

patch b752ceb6469f5f49b4d7f3c033f3c0dcd64b799a
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar 24 08:25:32 CET 2021
  * remove overspecification of pending from tests
  
  The test scripts should not prescribe the concrete format of the pending
  patch, not even an empty one.

patch 4ae1e19fd0b4a8d49ba31481caef710ce41e132c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Mar  3 12:02:26 CET 2021
  * harness: run test-framework with explicit RunnerOptions

patch c7f52e5cd185671c1022e9751a1e87ddc21b75ef
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu May 27 18:19:20 CEST 2021
  * tests: mark issue1014 as no longer failing
  
  After fixing a few minor issues in the test script, this test succeeds for
  darcs-3 as that fixes the underlying issue. However, the test script needed
  a few minor fixes to actually fail for the right reason. In particular,
  cloning a conflicted repo nowadays applies conflict markup, which we have to
  revert before pulling, otherwise we get prompted and the test fails with
  "promptChar: unexpected end of input".

patch bf1b80bc76857f40190c4543cdc326cc0cfa7193
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu May 27 18:40:14 CEST 2021
  * test for issue1579 no longer fails

patch b455a3beca721076c9e20b6c328f9a30c4293f9e
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu May 27 18:52:30 CEST 2021
  * tests for issue1327 and issue2047 fail only for darcs-1 and darcs-2

patch 6ca7649c6dfc443237c26a8747a567bb45875111
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat May 29 17:39:06 CEST 2021
  * tests/network/show_tags-remote.sh: remove directories

Attachments

• patch-preview.txt
• remove-overspecification-of-pending-from-tests.dpatch
• unnamed

> I don't want to make your life harder unnecessarily so if you still
> prefer to have this change after considering my comment, I'm ok with it
> being applied centrally. I know from experience that it's a pain and
> source of possible accidents to be maintaining changes locally only.

I'll think about it but for the moment I am fine with just leaving it
out. All the patches I have been sending today are just easy stuff I
want to get out of the way so that it's easier to prepare sensible
bundles for the more interesting changes.