darcs

Patch 2195 fix stale lock files after Ctrl-C (and two more)

Title fix stale lock files after Ctrl-C (and two more)
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2021-06-07.14:13:29 by bfrk, last changed 2021-11-27.17:04:47 by ganesh.

Files
File name Status Uploaded Type Edit Remove
cleanup-darcs_util_atexit.dpatch bfrk, 2021-06-07.14:17:42 application/x-darcs-patch
fix-stale-lock-files-after-ctrl_c.dpatch bfrk, 2021-06-07.14:13:29 application/x-darcs-patch
patch-preview.txt bfrk, 2021-06-07.14:13:29 text/x-darcs-patch
patch-preview.txt bfrk, 2021-06-07.14:17:42 text/x-darcs-patch
unnamed bfrk, 2021-06-07.14:13:29 text/plain
unnamed bfrk, 2021-06-07.14:17:42 text/plain
See mailing list archives for discussion on individual patches.
Messages
msg22870 (view) Author: bfrk Date: 2021-06-07.14:13:29
1 patch for repository http://darcs.net/screened:

patch 334bb99fd8c99883739b1b757f80fcac304b98cc
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Mar  4 07:48:25 CET 2021
  * fix stale lock files after Ctrl-C
  
  This changes the order of the handlers in the main function of the darcs
  executable, so that atexit is handled earlier than signals. This should also
  have the effect of removing temporary files and directories created using
  withDelayedDir in a more reliable manner.
  
  Both handleErrors and handleExecFail are uncritical, they merely re-classify
  and annotate certain exceptions and report them in a more user friendly
  fashion, so handleExitFail was also moved out of the withSignalsHandled.
Attachments
msg22871 (view) Author: bfrk Date: 2021-06-07.14:17:42
Forgot to add these related patches to the bundle.

2 patches for repository http://darcs.net/screened:

patch 444f2ac895424fe28b35ef31352065f4a0ec5daf
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Mar  4 08:32:26 CET 2021
  * cleanup Darcs.Util.AtExit
  
  Apart from layout changes, this replaces bracket_ with finally and removes
  the extra mask/unmask stuff; the exit action of bracket/finally is executed
  in masked state anyway, so any further masking/unmasking has no effect.

patch 0c180a0852ddfe49937bf9e53fb3e7c4fd88d258
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu Mar  4 08:48:01 CET 2021
  * streamline the code in the darcs main module
Attachments
msg22933 (view) Author: ganesh Date: 2021-11-22.07:46:41
All fine.
History
Date User Action Args
2021-06-07 14:13:29bfrkcreate
2021-06-07 14:13:41bfrksetstatus: needs-screening -> needs-review
2021-06-07 14:17:43bfrksetfiles: + patch-preview.txt, cleanup-darcs_util_atexit.dpatch, unnamed
messages: + msg22871
title: fix stale lock files after Ctrl-C -> fix stale lock files after Ctrl-C (and two more)
2021-11-22 07:46:41ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg22933
2021-11-27 17:04:47ganeshsetstatus: accepted-pending-tests -> accepted