darcs

Patch 2209 release/gen-version-info.hs: fix missing... (and 1 more)

Title release/gen-version-info.hs: fix missing... (and 1 more)
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2021-07-13.09:55:58 by bfrk, last changed 2023-03-24.23:21:48 by ganesh.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2021-07-13.09:55:57 text/x-darcs-patch
release_gen_version_info_hs_-fix-missing-check-for-existence-of-_darcs.dpatch bfrk, 2021-07-13.09:55:57 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg22907 (view) Author: bfrk Date: 2021-07-13.09:55:57
2 patches for repository http://darcs.net/screened:

patch 684134a7380f9217159428e7fb17fd56f968e7f4
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed Jul  7 13:58:39 CEST 2021
  * release/gen-version-info.hs: fix missing check for existence of _darcs

patch 8377c017dd694e4034bc87634773ebc46e14e4a8
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Jul 10 09:34:31 CEST 2021
  * re-write of release/gen-version-info.hs

  This simplifies the logic but also replaces the test for existence of _darcs
  with catching all IOExceptions. This makes it more robust in case executing
  darcs fails for some other reason.
Attachments
msg23148 (view) Author: ganesh Date: 2023-03-18.20:35:06
Do we ever want to run `gen-version-info` in a non-checkout?
It's run from `release.sh` which makes various other assumptions
that it can run darcs.
msg23161 (view) Author: bfrk Date: 2023-03-22.16:07:08
The standard situation is `cabal install darcs` inside a fresh clone. 
Here, cabal internally performs an `sdist`, unpacks it in a tmp 
location and then builds that.
msg23162 (view) Author: ganesh Date: 2023-03-22.19:17:56
> The standard situation is `cabal install darcs` inside a fresh clone.
> Here, cabal internally performs an `sdist`, unpacks it in a tmp
> location and then builds that.

Ah, and it's run from `Setup.hs` too. I missed that.
History
Date User Action Args
2021-07-13 09:55:59bfrkcreate
2021-07-13 09:57:07bfrksetstatus: needs-screening -> needs-review
2023-03-18 20:35:08ganeshsetstatus: needs-review -> review-in-progress
messages: + msg23148
2023-03-22 16:07:08bfrksetmessages: + msg23161
2023-03-22 19:17:57ganeshsetstatus: review-in-progress -> accepted-pending-tests
messages: + msg23162
2023-03-24 23:21:48ganeshsetstatus: accepted-pending-tests -> accepted