Patch 2212: lift writeInventoryPrivate to the top le... (and 2 more) - Darcs bug tracker

Title	lift writeInventoryPrivate to the top le... (and 2 more)
Superseder		Nosy List	bf
Related Issues
Status	review-in-progress	Assigned To
Milestone

Created on 2021-11-03.23:06:29 by bf, last changed 2023-03-19.00:32:45 by ganesh.

Files
File name	Status	Uploaded	Type	Edit	Remove
lift-writeinventoryprivate-to-the-top-level-and-rename-to-writeinventory.dpatch		bf, 2021-11-03.23:06:28	application/x-darcs-patch
patch-preview.txt		bf, 2021-11-03.23:06:27	text/x-darcs-patch

See mailing list archives for discussion on individual patches.

Messages
msg22915 (view)	Author: bf	Date: 2021-11-03.23:06:28
3 patches for repository http://darcs.net/screened: patch 36028bf066c9754dcccbd300a8889399c1b5a82b Author: Ben Franksen <ben.franksen@online.de> Date: Tue Nov 3 07:34:16 CET 2020 * lift writeInventoryPrivate to the top level and rename to writeInventory patch f6b14b28d588cefdf6679a0a197dbafbbc707afa Author: Ben Franksen <ben.franksen@online.de> Date: Wed Mar 24 06:37:23 CET 2021 * simplify writeInventory and writeTentativeInventory The simplification consists of no longer treating empty inventories specially. It involves is a minor change in behavior in that an empty inventory is now written to disk as a hashed file; which is the reason we have to adapt tests/issue1987.sh. Indeed, my original motivation for the refactor was so to make writeInventory return a hash unconditionally. patch ab64067074f7843d61d3ca2859effa28afb2dc0f Author: Ben Franksen <ben.franksen@online.de> Date: Wed Mar 24 18:26:07 CET 2021 * return hash from writePristine Attachments lift-writeinventoryprivate-to-the-top-level-and-rename-to-writeinventory.dpatch patch-preview.txt
msg23150 (view)	Author: ganesh	Date: 2023-03-19.00:32:45
> It involves is a minor change in behavior in that an empty inventory is now written to disk as a hashed file This seems like a good simplification. Do we need to do anything to check that older darcs will read the new empty inventories ok?

History
Date	User	Action	Args
2021-11-03 23:06:29	bf	create
2021-11-04 06:38:43	bf	set	status: needs-screening -> needs-review
2023-03-19 00:32:45	ganesh	set	status: needs-review -> review-in-progress messages: + msg23150