darcs

Patch 2242 collection of minor/trivial cleanups and fixes

Title collection of minor/trivial cleanups and fixes
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2022-06-02.09:42:38 by bfrk, last changed 2023-06-06.10:22:15 by bfrk.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2022-06-02.09:42:27 text/x-darcs-patch
remove-a-duplicate-import.dpatch bfrk, 2022-06-02.09:42:27 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg23002 (view) Author: bfrk Date: 2022-06-02.09:42:27
Will probably self-accept these.

25 patches for repository http://darcs.net/screened:

patch 56c1137b1cac5d754c3bb0ce6211c7b77cdef6c2
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Nov 22 09:53:13 CET 2021
  * remove a duplicate import

patch 392a088077bc9ea5e84b2e984ec3d0a286fd1321
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon Nov 22 09:53:40 CET 2021
  * catch all IOErrors when removing temporary directories

  I have occasionally observed tests failing in the CI that say

   darcs: /tmp/darcs.log-75c76c279e1ab188_done/_darcs/patches:
   removePathForcibly:removePathForcibly:removePathForcibly:removeDirectory:
   unsatisfied constraints (Directory not empty)

  Catching these exception is justified because this is mere cleanup. Note
  that we already do the same thing in the cleanup part of withNewDirectory.

patch af29ebbb3a63b24a583e5c0f0c6059a417aab2b3
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri Apr 29 14:09:07 CEST 2022
  * .stylish-haskell.yaml: don't break single-constructor records

patch 87c006f74e25325a733ab2d2a845787808d19ee7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Apr 30 11:29:38 CEST 2022
  * Darcs.Util.Index: fix outdated haddocks

patch 8549e2cb38e95ef1c0aeea26d4bccfa85630e539
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun May  1 14:42:45 CEST 2022
  * harness: fix quoting env stuff for shell evaluation

  Using 'show' here is just wrong (it fails with spaces or non-ASCII
  characters).

patch ab68b0627c711c20837cce4185f93b4f2eba2f67
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun May  1 15:06:33 CEST 2022
  * harness: fix output of darcs executable under test

  Since it says "Using darcs executable in" I expect to see the directory in
  which the darcs executable was found.

patch f8e1dcb47d4ecbfcf9f4b77f51aba0381ddb3af5
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun May  1 15:10:22 CEST 2022
  * tests/lib: fix definition of 'which'

  In bash, 'type -P x' returns the full path where executable 'x' was found
  and nothing else.

patch 683aebb17c3e527ca8f0c6e602620d9e0f901062
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun May  1 15:13:42 CEST 2022
  * tests/latin9-input.sh: remove obsolete code

patch f859eae431a9d27f3d94c36a388b26e98b75b9ca
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun May  1 14:40:47 CEST 2022
  * rollback 856baf0c aka "Fix darcs-test on Win32 + GHC 6.12+."

  This is no longer needed and improves display of paths if they contain
  non-ASCII characters.

patch 7077bde779520519eafed6e3efc52cb718a41968
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu May  5 20:23:16 CEST 2022
  * rollback of "work-around to allow build with ghc >= 9.0 on Windows"

  The cabal problem was fixed upstream (in ansi-terminal-0.11.2).

patch dc859c89ab2b9a1454d783a719902e8bfb07438c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Thu May  5 20:25:02 CEST 2022
  * enable tests/utf8-display on Windows

  The test succeeds on Windows in the CI.

patch 68ee3301be9cf18cf22899dbd69b3874911518fd
Author: Ben Franksen <ben.franksen@online.de>
Date:   Mon May  9 19:00:48 CEST 2022
  * remove obsolete use of Windows #ifdefs in Darcs.Util.File

patch 971265f24fb29871561b281378389b5d4c07595b
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri May 13 07:39:28 CEST 2022
  * ci: run tests with i=yn and --hide

patch 8489ac8be5e0d9e18af86e92839b52ade465aa1f
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri May 13 07:39:48 CEST 2022
  * ci: use haskell/actions/setup@v2

patch 786a7483c00178b4d00baf0c328be0a0b47c1dbd
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri May 13 09:15:41 CEST 2022
  * tests: some trivial cleanups

patch 40643ce849903c492fdf4a6f1ab0e79143d1e17d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri May 13 12:15:58 CEST 2022
  * remove unused Darcs.Utile.Path.breakOnDir

patch 17bc64d6cfd20488858bb0a0663bd0c60f5cb714
Author: Ben Franksen <ben.franksen@online.de>
Date:   Fri May 13 12:47:47 CEST 2022
  * Darcs.Util.Path.pathToPosix: avoid mapping id on Posix

patch d2e877abe07be3bd475390cd5f644d329ac790ea
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat May 21 10:43:59 CEST 2022
  * darcs.cabal: remove duplicate build-depends entry

patch 50a3b69ba043d3dc17a75c9b4b33489397f73245
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat May 21 10:49:38 CEST 2022
  * rename cloneXxx to copyXxx, remove cloneFile

patch 670f964eafb505115a3e7d2ffa3fbffca23ca927
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat May 21 21:22:23 CEST 2022
  * hlint Darcs.Util.Lock

patch 0667ff4b032e0089be107eb8dc0c1add6a6fdea9
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun May 22 12:53:15 CEST 2022
  * remove obsolete src/hscurl.*

patch dc711a287f628852d76dcbb3edb9090c5e51115b
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat May 21 11:52:28 CEST 2022
  * move all of Darcs.Util.External to Darcs.Util.File

  To break an import cycle this also moves withTemp and withOpenTemp
  from darcs.Util.Lock to Darcs.Util.File.

patch 38a931de6c40e35020edad674e4d5dafd3049e88
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat May 21 21:22:02 CEST 2022
  * hlint Darcs.Util.Cache

patch 5df97ccbe6a5f780220834bef79feebec65b8b0d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat May 21 12:19:52 CEST 2022
  * move osxCacheDir and xdgCacheDir to D.R.Prefs

patch 9c5eaad7b1d60d62c544020f59f10bd6af769e0c
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat May 21 12:48:56 CEST 2022
  * document and cleanup Darcs.Util.File
Attachments
msg23264 (view) Author: bfrk Date: 2023-04-02.16:54:40
self-accept (trivial or non-essential changes only)
History
Date User Action Args
2022-06-02 09:42:38bfrkcreate
2022-06-02 09:44:42bfrksetstatus: needs-screening -> needs-review
2023-04-02 16:54:42bfrksetstatus: needs-review -> accepted-pending-tests
messages: + msg23264
2023-06-06 10:22:15bfrksetstatus: accepted-pending-tests -> accepted