Patch 2243: fix: hard-linking between repo and cache should be ent...

Title	fix: hard-linking between repo and cache should be ent...
Superseder		Nosy List	bf
Related Issues
Status	needs-review	Assigned To
Milestone

Created on 2022-06-02.11:24:16 by bf, last changed 2022-06-02.20:57:01 by bf.

Files
File name	Status	Uploaded	Type	Edit	Remove
fix_-hard_linking-between-repo-and-cache-should-be-entirely-optional.dpatch		bf, 2022-06-02.11:24:10	application/x-darcs-patch
patch-preview.txt		bf, 2022-06-02.11:24:10	text/x-darcs-patch

See mailing list archives for discussion on individual patches.

msg23003 (view)

Author: bf

Date: 2022-06-02.11:24:10

1 patch for repository http://darcs.net/screened:

patch a91e09b41fd2dddd651e768d8b40798f494f3f70
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed May 25 23:52:34 CEST 2022
  * fix: hard-linking between repo and cache should be entirely optional

  This fixes a bug introduced in

  patch 018c5978374ec2cb3ae4f918d733da948bda73da
  Author: Ben Franksen <ben.franksen@online.de>
  Date:   Mon Nov  9 15:47:50 CET 2020
    * improve cache utilization

  tryLinking catches only "does not exist" errors, so when hard-linking is
  optional, such as after we wrote the file to the repo, we should catch all
  exceptions. Note that tryLinking is *supposed* to throw exceptions, the
  logic in writeFileUsingCache depends on it.

  This came up in a situation where the repo and cache happened to be on
  different file systems, which caused most darcs commands to fail. I added a 
  line to tests/lib to run the tests in such a scenario, but it depends on a
  particular system setup and is therefore commented out.

Attachments

History
Date	User	Action	Args
2022-06-02 11:24:16	bf	create
2022-06-02 20:57:01	bf	set	status: needs-screening -> needs-review

Patch 2243 fix: hard-linking between repo and cache should be ent...

Attachments