1 patch for repository http://darcs.net/screened:

patch a91e09b41fd2dddd651e768d8b40798f494f3f70
Author: Ben Franksen <ben.franksen@online.de>
Date:   Wed May 25 23:52:34 CEST 2022
  * fix: hard-linking between repo and cache should be entirely optional

  This fixes a bug introduced in

  patch 018c5978374ec2cb3ae4f918d733da948bda73da
  Author: Ben Franksen <ben.franksen@online.de>
  Date:   Mon Nov  9 15:47:50 CET 2020
    * improve cache utilization

  tryLinking catches only "does not exist" errors, so when hard-linking is
  optional, such as after we wrote the file to the repo, we should catch all
  exceptions. Note that tryLinking is *supposed* to throw exceptions, the
  logic in writeFileUsingCache depends on it.

  This came up in a situation where the repo and cache happened to be on
  different file systems, which caused most darcs commands to fail. I added a 
  line to tests/lib to run the tests in such a scenario, but it depends on a
  particular system setup and is therefore commented out.

Attachments

• fix_-hard_linking-between-repo-and-cache-should-be-entirely-optional.dpatch
• patch-preview.txt

OK (maybe worth a comment in the code?)

Good idea to add comments for these cases.

1 patch for repository http://darcs.net/screened:

patch 02a66b8b83916dbed69029a22292880285aa5f91
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Jun 25 22:20:37 CEST 2023
  * cache: explain why we use catchall when hard-linking is optional

Attachments

• cache_-explain-why-we-use-catchall-when-hard_linking-is-optional.dpatch
• patch-preview.txt