Patch 2247 refactor askAboutDepends and updatePatchHeader

Title refactor askAboutDepends and updatePatchHeader
Superseder Nosy List bf
Related Issues
Status needs-review Assigned To

Created on 2022-06-08.07:34:23 by bf, last changed 2022-06-08.07:35:04 by bf.

File name Status Uploaded Type Edit Remove
patch-preview.txt bf, 2022-06-08.07:34:20 text/x-darcs-patch
refactor-askaboutdepends-and-updatepatchheader.dpatch bf, 2022-06-08.07:34:20 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
msg23010 (view) Author: bf Date: 2022-06-08.07:34:20
1 patch for repository http://darcs.net/screened:

patch 0f939713867ee7f22f842f1dc0de3e3fa4b7aff6
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Nov  3 19:46:46 CET 2020
  * refactor askAboutDepends and updatePatchHeader

  My immediate goal with this was to avoid making repository requests inside
  updatePatchHeader. Thus AskAboutDeps now contains a PatchSet instead of a
  Repository. But for the amend command the patchset we pass in is not the
  recorded patches but rather the recorded patches minus the selected patch.
  So we have to reconstruct this patchset. This is best done by not throwing
  away patches in the first place, but instead return unselected patches from
  filterNotInRemote as well as withSelectedPatchFromList. Incidentally this
  fixes a problem when we de-select the latest clean tag: before this patch
  amend would print all patches in the repo. This is now avoided by calling
  contextPatches when --not-in-remote is /not/ in effect.
Date User Action Args
2022-06-08 07:34:23bfcreate
2022-06-08 07:35:04bfsetstatus: needs-screening -> needs-review