Patch 2256: fix: add missing dry-run guards when calling applyToWo... - Darcs bug tracker

Title	fix: add missing dry-run guards when calling applyToWo...
Superseder		Nosy List	bf
Related Issues
Status	accepted-pending-tests	Assigned To
Milestone

Created on 2022-06-13.10:53:03 by bf, last changed 2022-06-13.10:57:24 by bf.

Files
File name	Status	Uploaded	Type	Edit	Remove
fix_-add-missing-dry_run-guards-when-calling-applytoworking.dpatch		bf, 2022-06-13.10:53:02	application/x-darcs-patch
patch-preview.txt		bf, 2022-06-13.10:53:02	text/x-darcs-patch

See mailing list archives for discussion on individual patches.

Messages
msg23021 (view)	Author: bf	Date: 2022-06-13.10:53:02
1 patch for repository http://darcs.net/screened: patch 6f1da77315dc7abba37768c5004907604046f4e5 Author: Ben Franksen <ben.franksen@online.de> Date: Tue Mar 2 15:11:45 CET 2021 * fix: add missing dry-run guards when calling applyToWorking applyToWorking is done after we finalize the transaction, indeed it isn't guarded by the transaction at all, since we cannot enforce mutual exclusion in the working tree. Attachments fix_-add-missing-dry_run-guards-when-calling-applytoworking.dpatch patch-preview.txt
msg23022 (view)	Author: bf	Date: 2022-06-13.10:57:24
self accept To elaborate the long comment: for the transacted parts --dry-run is taken care of by the DryRun parameter to finalizeRepositoryChanges.

History
Date	User	Action	Args
2022-06-13 10:53:03	bf	create
2022-06-13 10:57:24	bf	set	status: needs-screening -> accepted-pending-tests messages: + msg23022