Patch 2271 t/clone.sh: add some basic clone tests (and 2 more)

Title t/clone.sh: add some basic clone tests (and 2 more)
Superseder Nosy List gpiero
Related Issues
Status review-in-progress Assigned To

Created on 2022-12-18.21:55:28 by gpiero, last changed 2023-02-19.08:43:22 by bf.

File name Status Uploaded Type Edit Remove
patch-preview.txt dead gpiero, 2022-12-18.21:55:27 text/x-darcs-patch
t_clone_sh_-add-some-basic-clone-tests.dpatch dead gpiero, 2022-12-18.21:55:27 application/x-darcs-patch
t_clone_sh_-add-some-basic-clone-tests.dpatch dead gpiero, 2022-12-19.21:21:24 text/plain
t_network_ssh_sh_-also-test-clone-to-a-remote-target-containing-trailing-slashes.dpatch dead gpiero, 2022-12-31.16:01:16 text/plain
t_network_ssh_sh_-clone-to-a-remote-target-using-ssh___-uri-and-trailing-slash.dpatch gpiero, 2023-02-07.17:48:52 text/plain
See mailing list archives for discussion on individual patches.
msg23056 (view) Author: gpiero Date: 2022-12-18.21:55:27
This is mildly annoying to me:

$ darcs clone . remote:dir
works, but
$ darcs clone . remote:dir/

Allowing the latter makes darcs behave the same regardless of the target dir
being local or remote.

3 patches for repository http://darcs.net/screened:

patch 5da08695dc1ecb221a8bb6e9331ce4738d07a8f4
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Sun Dec 18 21:46:31 CET 2022
  * t/clone.sh: add some basic clone tests

patch 1316fe08bad1b5daa3857627a2b62685b3ddf37e
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Sun Dec 18 22:32:35 CET 2022
  * t/network/ssh.sh: also test clone to a remote target containing trailing slashes

patch 4f7e76c95d19efd74c8a8b565fadee9a4b8b9846
Author: Gian Piero Carrubba <gpiero@rm-rf.it>
Date:   Sun Dec 18 22:16:30 CET 2022
  * allow trailing slashes when cloning to a remote ssh target
msg23058 (view) Author: gpiero Date: 2022-12-19.21:21:25
Amended bundle. The previous one failed in the case:

$ darcs clone . remote:/

This is still not permitted, but for other reasons independent from this 
patch. Moreover, the revised patch also fixes the case:

$ darcs clone . ssh://...

that was previously failing.
msg23065 (view) Author: gpiero Date: 2022-12-31.16:01:16
Fixed tests. Is it ok to only send the amended patches, or should I 
resend the whole bundle?
msg23070 (view) Author: ganesh Date: 2022-12-31.22:35:33
It should be possible to apply the patches you intend by selecting some 
subset of the attached `.dpatch` files and applying everything in them.

I think that means you should resend the whole bundle in this case.

It's also helpful, at least for the tooling I use to process patches on 
the tracker, to use the edit link on the .dpatch files that are no 
longer needed and mark them as "dead". At least if you have permissions 
msg23072 (view) Author: ganesh Date: 2023-01-01.15:19:50
I think the changes look good. Could you maybe add a comment to 
`sshCanonRepo` to describe what it is trying to achieve?
msg23091 (view) Author: gpiero Date: 2023-02-07.17:49:00
Updated bundle.
msg23104 (view) Author: bf Date: 2023-02-19.08:43:22
I have pushed your latest bundle to screened.
Date User Action Args
2022-12-18 21:55:28gpierocreate
2022-12-19 21:21:26gpierosetfiles: + t_clone_sh_-add-some-basic-clone-tests.dpatch
messages: + msg23058
2022-12-31 16:01:17gpierosetfiles: + t_network_ssh_sh_-also-test-clone-to-a-remote-target-containing-trailing-slashes.dpatch
messages: + msg23065
2022-12-31 22:35:33ganeshsetmessages: + msg23070
2023-01-01 15:19:50ganeshsetstatus: needs-screening -> review-in-progress
messages: + msg23072
2023-02-07 17:49:03gpierosetfiles: + t_network_ssh_sh_-clone-to-a-remote-target-using-ssh___-uri-and-trailing-slash.dpatch
messages: + msg23091
2023-02-19 08:43:22bfsetmessages: + msg23104