darcs

Patch 2309 improved display of conflicts

Title improved display of conflicts
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To
Milestone

Created on 2023-06-17.10:57:53 by bfrk, last changed 2023-07-19.07:55:41 by bfrk.

Files
File name Status Uploaded Type Edit Remove
patch-preview.txt bfrk, 2023-06-17.10:57:48 text/x-darcs-patch
repopatchv3_-improved-display-of-conflictors.dpatch bfrk, 2023-06-17.10:57:48 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg23323 (view) Author: bfrk Date: 2023-06-17.10:57:48
2 patches for repository http://darcs.net/screened:

patch 58901b1ae2881f1b11d385610d959be53a095bdb
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Dec 24 07:29:45 CET 2022
  * RepoPatchV3: improved display of conflictors

  It now displays the effect, followed by the (in-effective) conflicting
  alternatives in a way that is similar to conflict markup (though minus
  display of the base). This is easier to parse for humans and more
  informative than a dump of the internal structure of a conflictor.

  Unfortunately it is not so easy to do this for RepoPatchV1 or V2.

patch a467d1bd53846201882a37a2e4c0d7042c2cd3f7
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sun Dec 25 07:29:29 CET 2022
  * improve display of "conflicted" RebaseChange

  The previous, simpler method displayed them as a "large" conflict of the
  whole patch with the inverse of the fixups. It is now more fine-grained,
  showing conflicts inline per prim. This works by choosing RepoPatchV3 to
  wrap prims and then display the result of a forceCommute with the residual
  fixups. Special care needs to be taken to filter out leading inverse pairs
  that forceCommute temporarily injects into the patch (a hack that was needed
  to make it work with RepoPatchV3).
Attachments
msg23604 (view) Author: ganesh Date: 2023-07-16.20:47:48
Both fine, though I would like to disentangle Rebase from RepoPatchV3.
msg23619 (view) Author: bfrk Date: 2023-07-19.07:55:41
> disentangle Rebase from RepoPatchV3

I agree tha would be nice. The problem is that we have to deal with 
a series of fixups stuck against another series of prims (from the 
Named patch). So far I haven't found a way to calculate conflicting 
alternatives from that in some elementary way i.e. w/o re-inventing 
conflictors.
History
Date User Action Args
2023-06-17 10:57:53bfrkcreate
2023-06-17 10:59:59bfrksetstatus: needs-screening -> needs-review
2023-07-16 20:47:48ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg23604
2023-07-16 20:53:13ganeshsetstatus: accepted-pending-tests -> accepted
2023-07-19 07:55:41bfrksetmessages: + msg23619