darcs

Patch 2348 trivial simplification (and 2 more)

Title trivial simplification (and 2 more)
Superseder Nosy List bfrk
Related Issues
Status accepted Assigned To bfrk
Milestone

Created on 2023-08-19.12:10:08 by bfrk, last changed 2023-08-19.14:57:31 by bfrk.

Files
File name Status Uploaded Type Edit Remove
fix-tests_mark_conflicts_sh.dpatch bfrk, 2023-08-19.14:10:47 application/x-darcs-patch
patch-preview.txt bfrk, 2023-08-19.12:10:06 text/x-darcs-patch
patch-preview.txt bfrk, 2023-08-19.14:10:47 text/x-darcs-patch
trivial-simplification.dpatch bfrk, 2023-08-19.12:10:07 application/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg23680 (view) Author: bfrk Date: 2023-08-19.12:10:07
Trivial cleanups, will self-accept.

3 patches for repository http://darcs.net/screened:

patch d7ee08f51fb51f50038d432c0df6e2011f4df505
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Jul  1 08:11:19 CEST 2023
  * trivial simplification

patch 8de38dd6b119a48f388de669bcbe6b1011a8f579
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Jul 29 16:06:22 CEST 2023
  * tests/mark-conflicts.sh cleanup

patch c59efa383a146be7e26958a24d1975cfee17dde2
Author: Ben Franksen <ben.franksen@online.de>
Date:   Tue Aug  1 15:59:53 CEST 2023
  * remove two obsolete re-exports
Attachments
msg23681 (view) Author: bfrk Date: 2023-08-19.12:58:05
This breaks tests/mark-conflicts.sh when I apply it to reviewed. 
Probably a missing semantic dependency.
msg23683 (view) Author: bfrk Date: 2023-08-19.14:10:47
1 patch for repository http://darcs.net/screened:

patch f0472b439ce5467adf43c7d46536a1e6df54074d
Author: Ben Franksen <ben.franksen@online.de>
Date:   Sat Aug 19 16:06:19 CEST 2023
  * fix tests/mark-conflicts.sh

  Before patch 8de38dd6 "tests/mark-conflicts.sh cleanup" we did not source
  lib, and therefore did not set -e, so the grep failures were ignored.
Attachments
History
Date User Action Args
2023-08-19 12:10:08bfrkcreate
2023-08-19 12:11:24bfrksetstatus: needs-screening -> accepted-pending-tests
2023-08-19 12:58:14bfrksetstatus: accepted-pending-tests -> followup-requested
assignedto: bfrk
messages: + msg23681
2023-08-19 14:10:48bfrksetfiles: + patch-preview.txt, fix-tests_mark_conflicts_sh.dpatch
messages: + msg23683
2023-08-19 14:57:31bfrksetstatus: followup-requested -> accepted