darcs

Patch 241 work around cabal flag composition bug

Title work around cabal flag composition bug
Superseder Nosy List dagit, kowey
Related Issues
Status accepted Assigned To
Milestone

Created on 2010-05-08.05:13:12 by dagit, last changed 2011-05-10.19:36:55 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
unnamed dagit, 2010-05-08.05:13:11
work-around-cabal-flag-composition-bug.dpatch dagit, 2010-05-08.05:13:11 text/x-darcs-patch
See mailing list archives for discussion on individual patches.
Messages
msg11018 (view) Author: dagit Date: 2010-05-08.05:13:11
1 patch for repository darcs.net:darcs:

The reason for the ugly "note" in the cabal file is a reminder to
future us to remove the workaround when cabal has a proper fix.

This patch is pretty minor both in terms of what it changes and how
important it is.  I think it could be "fast tracked", but it's also no
big deal if it doesn't get accepted.

What it it does:  Gets rid of that pesky warning for unused do
bindings on 6.12.  The line in the cabal file should have done it, but
cabal has a bug (at least my cabal 1.8.0.2), that means ghc was still
warning obessively.

Thanks,
Jason

Fri May  7 22:07:21 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * work around cabal flag composition bug
  There is a bug with the way cabal combines flags of different nesting
  levels in the .cabal file.  See ticket 684 for details:
  http://hackage.haskell.org/trac/hackage/ticket/684
Attachments
msg11019 (view) Author: kowey Date: 2010-05-08.07:46:17
On Sat, May 08, 2010 at 05:13:12 +0000, Jason Dagit wrote:
> This patch is pretty minor both in terms of what it changes and how
> important it is.  I think it could be "fast tracked", but it's also no
> big deal if it doesn't get accepted.

Speaking of fast-tracking, I keep forgetting what we decided, so I
went to
  http://wiki.darcs.net/Development/Policy
which sent me to
  http://wiki.darcs.net/Development/PatchReview
which told me that we can just push our build system patches at will
if we don't think they really need review.

> What it it does:  Gets rid of that pesky warning for unused do
> bindings on 6.12.  The line in the cabal file should have done it, but
> cabal has a bug (at least my cabal 1.8.0.2), that means ghc was still
> warning obessively.

OK, applied (pending tests...)

work around cabal flag composition bug
--------------------------------------
>    -- We need optimizations, regardless of what Hackage says
> -  ghc-options:      -Wall -O2 -funbox-strict-fields -fwarn-tabs
> +  -- Note: "if true" works around a cabal bug with order of flag composition
> +  if true
> +    ghc-options:      -Wall -O2 -funbox-strict-fields -fwarn-tabs

etc...

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg11021 (view) Author: darcswatch Date: 2010-05-08.08:06:01
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-05d2fc68addd5f6914962acba96806fbc5c154c6
msg14197 (view) Author: darcswatch Date: 2011-05-10.19:36:55
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-05d2fc68addd5f6914962acba96806fbc5c154c6
History
Date User Action Args
2010-05-08 05:13:12dagitcreate
2010-05-08 05:15:37darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-05d2fc68addd5f6914962acba96806fbc5c154c6
2010-05-08 07:46:17koweysetnosy: + kowey
messages: + msg11019
2010-05-08 08:06:01darcswatchsetstatus: needs-review -> accepted
messages: + msg11021
2011-05-10 19:36:55darcswatchsetmessages: + msg14197