Broke with my newset merge. Caught by the buildbot.

Yours,
    Petr.

1 patch for repository http://darcs.net:

Mon May 10 18:13:47 CEST 2010  Petr Rockai <me@mornfall.net>
  * Fix spurious backslashes in URIs on win32.

Attachments

• fix-spurious-backslashes-in-uris-on-win32_.dpatch
• unnamed

Fix spurious backslashes in URIs on win32.
------------------------------------------
> Petr Rockai <me@mornfall.net>**20100510161347
>  Ignore-this: 5232a642bba8fa0250c3eb9e46310130
> ] hunk ./src/Darcs/Repository/HashedRepo.hs 331
>  
>  read_inventory_private :: Cache -> String -> String -> IO (Maybe String, [(PatchInfo, String)])
>  read_inventory_private _ d iname = do
> -    i <- skip_pristine `fmap` fetchFilePS (d </> iname) Uncachable
> +    i <- skip_pristine `fmap` fetchFilePS (d ++ "/" ++ iname) Uncachable -- /, this is URL
>      (rest,str) <- case BC.break ((==)'\n') i of
>                    (swt,pistr) | swt == BC.pack "Starting with inventory:" ->
>                      case BC.break ((==)'\n') $ B.tail pistr of

This should go in, but this reminds me, don't we have a policy of using
System.FilePath.Posix specifically to avoid any risk of funny business?

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9

Eric Kow <kowey@darcs.net> writes:
> This should go in, but this reminds me, don't we have a policy of using
> System.FilePath.Posix specifically to avoid any risk of funny business?
I have no idea. It may be nice to get \ on windows in paths to avoid
confusion, but probably not worth the bugs. So if you think, supersede
the patch with an import fix.

A hlint policyfile update would be good, too, if we really do have that
policy (System.FilePath.(</>) is forbidden, use
System.FilePath.Posix.(</>)).

Yours,
   Petr.

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-5c45d752cb083e78cb4f097b3259f02f66f42c7d

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-5c45d752cb083e78cb4f097b3259f02f66f42c7d