darcs

Patch 263 Add test for issue 1503

Title Add test for issue 1503
Superseder Nosy List abuiles, kowey
Related Issues
Status accepted Assigned To kowey
Milestone

Created on 2010-06-03.19:25:26 by builes.adolfo, last changed 2011-05-10.22:36:12 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
add-test-for-issue-1503.dpatch builes.adolfo, 2010-06-03.19:25:26 text/x-darcs-patch
added-test-for-issue-1503_-prefer-local-caches-to-remote-ones.dpatch abuiles, 2010-06-08.01:46:42 text/x-darcs-patch
unnamed builes.adolfo, 2010-06-03.19:25:26
unnamed abuiles, 2010-06-08.01:46:42
unnamed abuiles, 2010-06-08.18:38:44 text/html
See mailing list archives for discussion on individual patches.
Messages
msg11221 (view) Author: abuiles Date: 2010-06-03.19:25:26
1 patch for repository http://darcs.net:

Thu Jun  3 14:07:21 COT 2010  builes.adolfo@googlemail.com
  * Add test for issue 1503
Attachments
msg11241 (view) Author: kowey Date: 2010-06-05.13:09:18
Hi Adolfo,

Add test for issue 1503
-----------------------
> ] addfile ./tests/network/issue1503_prefer_local_caches_to_remote_one.sh
> hunk ./tests/network/issue1503_prefer_local_caches_to_remote_one.sh 1
> +#!/usr/bin/env bash
> +set -ev
> +
> +rm -rf S T
> +darcs get --lazy http://darcs.net/testing/repo1 S
> +darcs tag --repo S -m 2
> +darcs get --lazy http://darcs.net/testing/repo1 T
> +darcs pull --repo T S -a

How does this test test issue1503?  It wasn't obvious to me, but I may
have just missed something.

By the way, it's a good habit to use EXAMPLE.sh as a template for tests.

Thanks,

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg11319 (view) Author: abuiles Date: 2010-06-08.01:46:42
1 patch for repository http://darcs.net:

Mon Jun  7 20:33:13 COT 2010  builes.adolfo@googlemail.com
  * Added test for issue 1503: prefer local caches to remote ones
Attachments
msg11321 (view) Author: kowey Date: 2010-06-08.08:42:00
Hi Adolfo,

On Tue, Jun 08, 2010 at 01:46:42 +0000, Adolfo Builes wrote:
> +rm -rf S T
> +darcs get --lazy http://darcs.net/testing/repo1 S
> +darcs tag --repo S -m 2
> +darcs get --lazy http://darcs.net/testing/repo1 T
> +darcs pull --repo T S -a --debug --verbose 2> log
> +not grep repo1 log

Have you checked that this test currently fails with HEAD darcs?

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg11322 (view) Author: kowey Date: 2010-06-08.08:58:38
> On Tue, Jun 08, 2010 at 01:46:42 +0000, Adolfo Builes wrote:
> > +rm -rf S T
> > +darcs get --lazy http://darcs.net/testing/repo1 S
> > +darcs tag --repo S -m 2
> > +darcs get --lazy http://darcs.net/testing/repo1 T
> > +darcs pull --repo T S -a --debug --verbose 2> log
> > +not grep repo1 log
> 
> Have you checked that this test currently fails with HEAD darcs?

Argh, sorry, I just got bitten by intellectual dyslexia (I'm not
sure what to call this phenomenon where I very frequently invert
False/True, up/down, positive/negative).  I meant have you checked
that this fails with released Darcs and succeeds with HEAD darcs?

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
PGP Key ID: 08AC04F9
msg11334 (view) Author: abuiles Date: 2010-06-08.18:38:44
Hi Eric


>  I meant have you checked  that this fails with released Darcs and succeeds
> with HEAD darcs?
>

Yes is tested with both versions.

--
Adolfo
Attachments
msg11539 (view) Author: kowey Date: 2010-06-22.09:18:07
I seem to have neglected to push this.  Sorry, Adolfo!
msg11544 (view) Author: darcswatch Date: 2010-06-22.10:02:25
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-17a630327f3a4cdeb22582cfa294d3e20df33b30
msg14348 (view) Author: darcswatch Date: 2011-05-10.21:36:06
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-17a630327f3a4cdeb22582cfa294d3e20df33b30
History
Date User Action Args
2010-06-03 19:25:26builes.adolfocreate
2010-06-03 19:26:14darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-3fdfffb9da74ab949259010955e56c6f3e3e499e
2010-06-05 13:09:18koweysetnosy: + kowey
messages: + msg11241
2010-06-05 13:18:15koweysetstatus: needs-review -> review-in-progress
assignedto: kowey
2010-06-08 01:46:42abuilessetfiles: + added-test-for-issue-1503_-prefer-local-caches-to-remote-ones.dpatch, unnamed
nosy: + abuiles
messages: + msg11319
2010-06-08 01:48:00darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-3fdfffb9da74ab949259010955e56c6f3e3e499e -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-17a630327f3a4cdeb22582cfa294d3e20df33b30
2010-06-08 08:42:00koweysetmessages: + msg11321
2010-06-08 08:58:38koweysetmessages: + msg11322
2010-06-08 18:38:44abuilessetfiles: + unnamed
messages: + msg11334
2010-06-22 09:18:07koweysetstatus: review-in-progress -> accepted-pending-tests
nosy: - builes.adolfo
messages: + msg11539
2010-06-22 10:02:25darcswatchsetstatus: accepted-pending-tests -> accepted
messages: + msg11544
2011-05-10 21:36:06darcswatchsetmessages: + msg14348
2011-05-10 22:36:12darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-17a630327f3a4cdeb22582cfa294d3e20df33b30 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-3fdfffb9da74ab949259010955e56c6f3e3e499e