darcs

Patch 286 Rollback foolhardy attempt to generalise bracketedFL.

Title Rollback foolhardy attempt to generalise bracketedFL.
Superseder Nosy List ganesh, kowey
Related Issues
Status rejected Assigned To ganesh
Milestone

Created on 2010-06-21.22:23:09 by kowey, last changed 2011-05-10.20:06:07 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
rollback-attempt-to-generalise-bracketedfl-_which-broke-witnesses__.dpatch kowey, 2010-06-21.22:26:46 text/x-darcs-patch
unnamed kowey, 2010-06-21.22:23:09
unnamed kowey, 2010-06-21.22:26:46
See mailing list archives for discussion on individual patches.
Messages
msg11534 (view) Author: kowey Date: 2010-06-21.22:23:09
Sorry everybody!  I broke the witness build with my issue1763 patch.

I should have tested this, but must have neglected to.
Worse, I don't think my original type signature actually made any
sense.

Also: I couldn't work out how to say what I wanted.  In this patch,
I just sort of give up and fix issue1763 via copy+paste programming.

1 patch for repository http://darcs.net:

Mon Jun 21 23:21:43 BST 2010  Eric Kow <kowey@darcs.net>
  * Rollback foolhardy attempt to generalise bracketedFL.
  The attempt broke the witness build.
  This patch uses code duplication to achieve the same result
  intended by the generalisation.
Attachments
msg11535 (view) Author: kowey Date: 2010-06-21.22:26:46
Oops, my first attempt was broken.  Try number 2 (with less editoralising
in the patch comments)

Ganesh: would you be able to look at this?

Thanks!

1 patch for repository http://darcs.net:

Mon Jun 21 23:28:05 BST 2010  Eric Kow <kowey@darcs.net>
  * Rollback attempt to generalise bracketedFL (which broke witnesses).
  This patch uses code duplication to achieve the same result
  intended by the generalisation.
Attachments
msg11537 (view) Author: ganesh Date: 2010-06-22.04:41:41
What patch contains the change you are rolling back?
msg11538 (view) Author: ganesh Date: 2010-06-22.07:30:30
The patch being (partially) rolled back is part of patch258:

Wed Jun  2 12:08:17 BST 2010  Eric Kow <kowey@darcs.net>
  * Bug fix: treat filenames in darcs-2 patches as raw bytes.
  (instead of trying to decode from UTF-8)

But actually the problem can be solved with just a tweak to the type 
signature, so I think this rollback is overkill. I'll send in the patch 
tonight.
History
Date User Action Args
2010-06-21 22:23:09koweycreate
2010-06-21 22:23:54darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-9ddaf32faafe24e25ad2509e236e9d4bdb1bab41
2010-06-21 22:26:46koweysetfiles: + rollback-attempt-to-generalise-bracketedfl-_which-broke-witnesses__.dpatch, unnamed
nosy: + ganesh
messages: + msg11535
2010-06-21 22:26:57koweysetfiles: - rollback-foolhardy-attempt-to-generalise-bracketedfl_.dpatch
2010-06-21 22:27:13koweysetassignedto: ganesh
2010-06-21 22:27:59darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-9ddaf32faafe24e25ad2509e236e9d4bdb1bab41 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-cf70e84b3a7852fcbb5c4becd4dd01f9aaec71b3
2010-06-22 04:41:41ganeshsetmessages: + msg11537
2010-06-22 07:30:30ganeshsetstatus: needs-review -> rejected
messages: + msg11538
2011-05-10 19:37:09darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-cf70e84b3a7852fcbb5c4becd4dd01f9aaec71b3 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-9ddaf32faafe24e25ad2509e236e9d4bdb1bab41
2011-05-10 20:06:07darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-9ddaf32faafe24e25ad2509e236e9d4bdb1bab41 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-cf70e84b3a7852fcbb5c4becd4dd01f9aaec71b3