Patch 293: Resolve issue1883: rename --patch-name option to --set... - Darcs bug tracker

Title	Resolve issue1883: rename --patch-name option to --set...
Superseder		Nosy List	ganesh, kowey
Related Issues	It's too easy to mix up --patch-name and --patch in some commands View: 1883
Status	accepted	Assigned To
Milestone

Created on 2010-07-01.01:29:10 by kowey, last changed 2011-05-10.22:05:55 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
resolve-issue1883_-rename-__patch_name-option-to-__name_.dpatch		kowey, 2010-07-12.15:21:32	text/x-darcs-patch
resolve-issue1883_-rename-__patch_name-option-to-__name_.dpatch		kowey, 2010-07-15.10:14:03	text/x-darcs-patch
resolve-issue1883_-rename-__patch_name-option-to-__set_patch_name_.dpatch		kowey, 2010-07-01.01:29:10	text/x-darcs-patch
resolve-issue1883_-rename-__patch_name-option-to-__set_patch_name_.dpatch		kowey, 2010-07-15.10:06:31	text/x-darcs-patch
unnamed		kowey, 2010-07-01.01:29:10
unnamed		kowey, 2010-07-12.15:21:32
unnamed		kowey, 2010-07-15.10:06:31
unnamed		kowey, 2010-07-15.10:14:03

See mailing list archives for discussion on individual patches.

Messages
msg11656 (view)	Author: kowey	Date: 2010-07-01.01:29:10
Don't apply this yet; wait at most a week for http://lists.osuosl.org/pipermail/darcs-users/2010-July/024424.html to spark some discussion then punch it. 1 patch for repository http://darcs.net: Thu Jul 1 02:26:39 BST 2010 Eric Kow <kowey@darcs.net> * Resolve issue1883: rename --patch-name option to --set-patch-name. This is usually used in darcs record in shorthand (-m) form. This rename is aimed at eliminating the confusion with the --patch matcher, which bites amend-record and rollback users. Attachments resolve-issue1883_-rename-__patch_name-option-to-__set_patch_name_.dpatch unnamed
msg11687 (view)	Author: ganesh	Date: 2010-07-06.19:40:09
The discussion on the review seemed to lead to agreement that --set-patch- name is a bad option name (and I also agree with that opinion). So I don't think this should go in in its current form.
msg11728 (view)	Author: kowey	Date: 2010-07-12.15:21:32
Amended following a much nicer idea from Reinier. 1 patch for repository http://darcs.net: Mon Jul 12 16:23:44 BST 2010 Eric Kow <kowey@darcs.net> * Resolve issue1883: rename --patch-name option to --name. This is usually used in darcs record in shorthand (-m) form. This rename is aimed at eliminating the confusion with the --patch matcher, which bites amend-record and rollback users. Attachments resolve-issue1883_-rename-__patch_name-option-to-__name_.dpatch unnamed
msg11752 (view)	Author: kowey	Date: 2010-07-15.10:06:31
1 patch for repository http://darcs.net: Amended to resolve conflict with patch285 Thu Jul 15 11:01:41 BST 2010 Eric Kow <kowey@darcs.net> * Resolve issue1883: rename --patch-name option to --set-patch-name. This is usually used in darcs record in shorthand (-m) form. This rename is aimed at eliminating the confusion with the --patch matcher, which bites amend-record and rollback users. ___________________________________________________________ This email has been scanned by MessageLabs' Email Security System on behalf of the University of Brighton. For more information see http://www.brighton.ac.uk/is/spam/ ___________________________________________________________ Attachments resolve-issue1883_-rename-__patch_name-option-to-__set_patch_name_.dpatch unnamed
msg11753 (view)	Author: kowey	Date: 2010-07-15.10:14:03
Thanks to Petr for noticing the incorrect patch name. 1 patch for repository http://darcs.net: Thu Jul 15 11:16:08 BST 2010 Eric Kow <kowey@darcs.net> * Resolve issue1883: rename --patch-name option to --name. This is usually used in darcs record in shorthand (-m) form. This rename is aimed at eliminating the confusion with the --patch matcher, which bites amend-record and rollback users. ___________________________________________________________ This email has been scanned by MessageLabs' Email Security System on behalf of the University of Brighton. For more information see http://www.brighton.ac.uk/is/spam/ ___________________________________________________________ Attachments resolve-issue1883_-rename-__patch_name-option-to-__name_.dpatch unnamed
msg11755 (view)	Author: darcswatch	Date: 2010-07-15.10:42:08
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-722ff81197af5526a6b44dbb4d672d9e9530cd3e
msg14136 (view)	Author: darcswatch	Date: 2011-05-10.19:05:33
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-722ff81197af5526a6b44dbb4d672d9e9530cd3e

History
Date	User	Action	Args
2010-07-01 01:29:10	kowey	create
2010-07-01 01:30:40	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-df1a32b3cced2462e3fb5a875a4376e28a027c40
2010-07-06 19:40:09	ganesh	set	status: needs-review -> followup-requested nosy: + ganesh messages: + msg11687
2010-07-06 19:40:14	ganesh	set	issues: + It's too easy to mix up --patch-name and --patch in some commands
2010-07-12 15:21:32	kowey	set	files: + resolve-issue1883_-rename-__patch_name-option-to-__name_.dpatch, unnamed messages: + msg11728
2010-07-12 15:21:56	kowey	set	status: followup-requested -> needs-review
2010-07-12 15:22:31	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-df1a32b3cced2462e3fb5a875a4376e28a027c40 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-1b996e0fb82dd90a4add4661d01d7dc4f82caab1
2010-07-15 10:06:31	kowey	set	files: + resolve-issue1883_-rename-__patch_name-option-to-__set_patch_name_.dpatch, unnamed messages: + msg11752
2010-07-15 10:08:52	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-1b996e0fb82dd90a4add4661d01d7dc4f82caab1 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-ef97de933a09ce79788e3918fac2b4338fb9511a
2010-07-15 10:14:03	kowey	set	files: + resolve-issue1883_-rename-__patch_name-option-to-__name_.dpatch, unnamed messages: + msg11753
2010-07-15 10:15:36	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-ef97de933a09ce79788e3918fac2b4338fb9511a -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-722ff81197af5526a6b44dbb4d672d9e9530cd3e
2010-07-15 10:42:08	darcswatch	set	status: needs-review -> accepted messages: + msg11755
2011-05-10 18:06:38	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-722ff81197af5526a6b44dbb4d672d9e9530cd3e -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-ef97de933a09ce79788e3918fac2b4338fb9511a
2011-05-10 19:05:33	darcswatch	set	messages: + msg14136
2011-05-10 21:36:08	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-ef97de933a09ce79788e3918fac2b4338fb9511a -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-1b996e0fb82dd90a4add4661d01d7dc4f82caab1
2011-05-10 22:05:55	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-1b996e0fb82dd90a4add4661d01d7dc4f82caab1 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-df1a32b3cced2462e3fb5a875a4376e28a027c40