Patch 36: DRAFT: Resolve issue1671: display expected hash. - Darcs bug tracker

Title	DRAFT: Resolve issue1671: display expected hash.
Superseder		Nosy List	darcs-users, kowey, twb
Related Issues
Status	rejected	Assigned To	kowey
Milestone

Created on 2009-11-01.09:15:33 by twb, last changed 2009-11-02.11:04:33 by kowey.

Files
File name	Status	Uploaded	Type	Edit	Remove
draft_-resolve-issue1671_-display-expected-hash_.dpatch		twb, 2009-11-01.09:15:31	text/x-darcs-patch
unnamed		twb, 2009-11-01.09:15:31	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg9159 (view)	Author: twb	Date: 2009-11-01.09:15:31
This addressed my immediate issue, but it should proably be prettied up a bit. Sun Nov 1 19:35:05 EST 2009 Trent W. Buck <trentbuck@gmail.com> * DRAFT: Resolve issue1671: display expected hash. Attachments draft_-resolve-issue1671_-display-expected-hash_.dpatch unnamed
msg9183 (view)	Author: kowey	Date: 2009-11-02.11:04:26
On Sun, Nov 01, 2009 at 09:20:58 +0000, Eric Kow wrote: > > + "Patch bundle failed hash!\n" ++ > > + "This probably means that the patch has been "++ > > + "corrupted by a mailer.\n"++ > > + "The most likely culprit is CRLF newlines." ++ > > + "\n\nExpected: " ++ show expected ++ > > + "\nReceived: " ++ show received The implementation seems fine (tiny refactor and readability tweak), but I've marked issue1671 wont-fix for fear of users shooting themselves in the foot (since you can delete the hash anyway). Thanks, though... -- Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow> PGP Key ID: 08AC04F9

History
Date	User	Action	Args
2009-11-01 09:15:33	twb	create
2009-11-01 23:49:58	kowey	set	assignedto: kowey nosy: + kowey
2009-11-02 11:04:33	kowey	set	status: needs-review -> rejected nosy: + darcs-users messages: + msg9183