This patch bundle looks bigger than it is.

It's really just very light refactoring to fix some broken windows.
There is one patch that is bigger and less orthogonal than I would
normally do.  I apologize for that.  That's one were I started being
more explicit about Witnesses imports and removed some re-exporting.
That line of work sort of exploded on me and I was just too lazy to
break it up into per-file patches.

On my machine there are 3 remaining warnings that I couldn't fix.  The
one about redundantly importing Prelude seems to be a GHC bug.  I
tried disabling deprecation warnings for the one about syntax but GHC
still complained, so that might also be a GHC bug.  The one about
scoped type variables extension I don't really mind so I didn't try to
fix.

I exploded the witnesses stuff into a few more modules as that fixes
some orphaned instances warnings and just generally gives a better
structure. I didn't add any license boiler plate to those modules.  If
people feel strongly about that boilerplate I'll it in a separate
patch if these are accepted.

Thanks,
Jason

36 patches for repository http://darcs.net:

Sun Aug 22 13:13:25 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * move dropWhileRL to Ordered.hs

Sun Aug 22 13:17:58 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * move dropWhileFL to Ordered.hs

Sun Aug 22 13:23:09 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Global.hs: remove import to fix warning

Sun Aug 22 13:54:19 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * ReadMonads.hs: remove unused lexStrings

Sun Aug 22 13:56:21 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Diff.hs: remove unused bindings

Wed Aug 25 00:15:13 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * URL.hs: fix warning about conditional import of debugFail

Wed Aug 25 00:30:38 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Info.hs: remove redundant imports

Wed Aug 25 00:39:52 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Internal.hs: remove warnings

Wed Aug 25 00:42:02 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Checkpoint.hs: remove redundant imports

Wed Aug 25 00:43:47 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Merge.hs: remove redundant import

Wed Aug 25 00:44:59 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Repository.hs: remove unused binding

Wed Aug 25 00:46:14 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Convert.lhs: remove redundant import

Wed Aug 25 00:49:44 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * MarkConflicts.hs: rename shadowed binding

Wed Aug 25 00:49:48 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * ShowAuthors.lhs: remove redundant import

Wed Aug 25 00:51:32 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * TrackDown.lhs: fix warnings

Wed Aug 25 01:02:44 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Depends.hs: add back catch all case to silence warning

Wed Aug 25 01:03:36 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * splitout parts of Darcs.Witnesses into new modules
  This allows us to remove an Orphan Instances warning.  I also look the
  liberty of regrouping the Witnesses modules in the .cabal file while I
  was adding new ones.

Wed Aug 25 01:07:04 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * HashedRepo.hs: clean up imports to fix warnings

Wed Aug 25 01:08:22 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * WhatsNew.lhs: fix warnings

Wed Aug 25 01:10:58 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Match.lhs: remove redundant imports

Wed Aug 25 01:12:27 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Commands/Diff.lhs: remove redundant import

Wed Aug 25 01:13:24 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Get.lhs: remove redundant import

Wed Aug 25 01:15:08 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * ShowFiles.lhs: rename shadowed binding

Wed Aug 25 01:16:21 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Population.hs: remove redundant imports

Wed Aug 25 01:18:14 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Annotate.lhs: remove redundant imports

Wed Aug 25 01:27:01 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * SelectChanges.hs: fix warnings

Wed Aug 25 01:29:48 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Commands/Apply.lhs: fix warnings

Wed Aug 25 01:31:11 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Commands/Record.lhs: remove redundant imports

Wed Aug 25 01:32:44 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Commands/Send.lhs: remove redundant imports

Wed Aug 25 01:34:12 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Commands/Unrecord.lhs: fix warnings

Wed Aug 25 01:35:36 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Commands/Unrevert.lhs: remove redundant imports

Wed Aug 25 01:39:20 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Commands/Pull.lhs: fix warnings

Wed Aug 25 01:43:40 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * Commands/Put.lhs: fix warnings

Wed Aug 25 01:43:59 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * ArgumentDefaults.lhs: fix warnings

Wed Aug 25 02:56:57 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * clean up Witnesses imports across codebase

Wed Aug 25 03:07:22 PDT 2010  Jason Dagit <dagit@codersbase.com>
  * fix unit test imports

Attachments

• move-dropwhilerl-to-ordered_hs.dpatch
• unnamed

I've pushed most of this. The only one I'm not quite sure about is this:

> Wed Aug 25 01:02:44 PDT 2010  Jason Dagit <dagit@codersbase.com>
>   * Depends.hs: add back catch all case to silence warning

because I remember that there were some GADT-related errors with that 
case, though it's possible that the way you added it back solves those. 
Have you tried the witnesses build with GHC 6.10? (I've now tried 6.12 
and it's ok there). If you've checked that too then it's fine to push 
yourself if you want.

I haven't checked with older GHC, but the wild card pattern doesn't need 
to type check (I actually couldn't get it to type check with a non-wild 
card).  It should be fine.  If it's not fine, aren't the build slaves 
supposed to catch that?

Jason

This patch bundle (with 36 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-6c9bb6a89d32b27e64aff336f401547dd7b2373b

This patch bundle (with 36 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-6c9bb6a89d32b27e64aff336f401547dd7b2373b