darcs

Patch 378 Organise unit tests into per-module groups. (and 1 more)

Title Organise unit tests into per-module groups. (and 1 more)
Superseder Nosy List ganesh, kowey
Related Issues
Status accepted Assigned To
Milestone

Created on 2010-09-01.13:49:43 by kowey, last changed 2011-05-10.21:35:37 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
remove-literate-haskell-from-darcs_test_unit_.dpatch kowey, 2010-10-19.22:55:50 text/x-darcs-patch
tidy-up-test-harness-warnings_.dpatch kowey, 2010-09-03.14:46:27 text/x-darcs-patch
unnamed kowey, 2010-09-01.13:49:42
unnamed kowey, 2010-09-03.14:46:27
unnamed kowey, 2010-10-19.22:55:50
See mailing list archives for discussion on individual patches.
Messages
msg12390 (view) Author: kowey Date: 2010-09-01.13:49:42
2 patches for repository http://darcs.net:

All this talk about testing gave me an itch to tidy up our current unit testing
infrastructure.  These should just be mostly hunk moves.

Wed Sep  1 14:27:41 BST 2010  Eric Kow <kowey@darcs.net>
  * Organise unit tests into per-module groups.
  
  The idea is that each module exports its own testSuite function
  and the main driver just imports all the testSuites.
  
  Note that this introduces a slight discrepency in that we have
  modules like Lcs which are out of the Darcs hierarchy, but whose
  tests appear as Darcs.Test.Lcs.

Wed Sep  1 14:45:49 BST 2010  Eric Kow <kowey@darcs.net>
  * Tidy up test harness warnings.


___________________________________________________________
This email has been scanned by MessageLabs' Email Security
System on behalf of the University of Brighton.
For more information see http://www.brighton.ac.uk/is/spam/
___________________________________________________________
Attachments
msg12437 (view) Author: kowey Date: 2010-09-03.14:46:27
5 patches for repository http://darcs.net:

Amends and replaces past version of this bundle.

Wed Sep  1 14:45:49 BST 2010  Eric Kow <kowey@darcs.net>
  * Tidy up test harness warnings.

Fri Sep  3 15:13:29 BST 2010  Eric Kow <kowey@darcs.net>
  * Reorganise unit tests: avoid parallel test hierarchy.
  
  Each module to export its own testSuite function and the main driver to
  just import them all. In nested hierarchies, parent packages should
  import, group and report the testSuites for their subPackages.
  
  As for avoiding the parallel hierarchy, this should reduce the
  maintenance burden of building a test suite, and also provide a way to
  testing non-exported functions.  We make an exception for Darcs.Patch,
  where tests require a lot of extra infrastructure and also are extremely
  verbose in themselves.

Fri Sep  3 15:17:39 BST 2010  Eric Kow <kowey@darcs.net>
  * Avoid needless incomplete matching in Darcs.Patch.Info test.

Fri Sep  3 15:30:23 BST 2010  Eric Kow <kowey@darcs.net>
  * Consolidate Darcs.Test into test module.

Fri Sep  3 15:46:20 BST 2010  Eric Kow <kowey@darcs.net>
  * Correct oversight in test reorganisation.


___________________________________________________________
This email has been scanned by MessageLabs' Email Security
System on behalf of the University of Brighton.
For more information see http://www.brighton.ac.uk/is/spam/
___________________________________________________________
Attachments
msg12515 (view) Author: ganesh Date: 2010-09-08.21:08:22
Am I right that most of the contents of Darcs.Test.Unit has moved to 
Darcs.Patch.Test? If so this might be better managed with a file move 
followed by moving the odds and ends around.
msg12518 (view) Author: kowey Date: 2010-09-09.07:37:53
I think you may be right (don't remember anymore how much of that is
Darcs.Patch.Test).

If there are deps, this could be a chance for me to play with rebase as
deep amend-record
msg12775 (view) Author: kowey Date: 2010-10-19.22:55:50
7 patches for repository http://darcs.net/screened:

Note that I gave up on trying to rescue this branch (due to conflicts),
and I didn't have a network connection at the time nor a local copy of
the rebase branch, tsk!

So I just decided to do it over again, but this time trying a bit
harder to go about it in a cleaner way.

I'm going to self-screen these seemingly obvious tidy-up bits, and follow up
with a patch that bakes tests into their own modules (which I'm starting to
be a bit skeptical about).

Mon Oct 18 18:49:15 BST 2010  Eric Kow <kowey@darcs.net>
  * Remove literate Haskell from Darcs.Test.Unit.

Mon Oct 18 15:15:59 BST 2010  Eric Kow <kowey@darcs.net>
  * Mark sections in test.hs.

Mon Oct 18 23:27:25 BST 2010  Eric Kow <kowey@darcs.net>
  * Consolidate unit test running logic into test harness.

Mon Oct 18 23:40:15 BST 2010  Eric Kow <kowey@darcs.net>
  * Tidier announcement for subcommute unit tests.

Mon Oct 18 23:42:09 BST 2010  Eric Kow <kowey@darcs.net>
  * Sweep Darcs.Email tests into a single suite.

Mon Oct 18 23:43:04 BST 2010  Eric Kow <kowey@darcs.net>
  * Sweep Darcs.Patch.Info tests into a single suite.

Tue Oct 19 07:40:19 BST 2010  Eric Kow <kowey@darcs.net>
  * Split unit tests into Darcs.Patch and miscellaneous ones.
Attachments
msg12879 (view) Author: ganesh Date: 2010-11-02.22:31:32
This all looks fine but is currently blocked on other unreviewed patches.
msg13133 (view) Author: darcswatch Date: 2010-11-21.12:12:09
This patch bundle (with 7 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-0d527fb1e923b5462f1c78eded1d1eb779ce6ca1
msg14328 (view) Author: darcswatch Date: 2011-05-10.21:35:37
This patch bundle (with 7 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-0d527fb1e923b5462f1c78eded1d1eb779ce6ca1
History
Date User Action Args
2010-09-01 13:49:43koweycreate
2010-09-01 13:50:42darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-7feb05c1714ed2f8f400e00c9cad14db8415dc0e
2010-09-03 14:21:36koweysetfiles: - organise-unit-tests-into-per_module-groups_.dpatch
2010-09-03 14:46:28koweysetfiles: + tidy-up-test-harness-warnings_.dpatch, unnamed
messages: + msg12437
2010-09-06 19:30:43darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-7feb05c1714ed2f8f400e00c9cad14db8415dc0e -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-c11705c2d78ff7294fa98837066f3941dccb4dc2
2010-09-08 21:08:22ganeshsetmessages: + msg12515
2010-09-08 21:08:27ganeshsetnosy: + ganesh
2010-09-09 07:37:53koweysetstatus: needs-review -> followup-in-progress
messages: + msg12518
2010-10-19 22:55:51koweysetfiles: + remove-literate-haskell-from-darcs_test_unit_.dpatch, unnamed
messages: + msg12775
2010-10-19 22:57:15darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-c11705c2d78ff7294fa98837066f3941dccb4dc2 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-0d527fb1e923b5462f1c78eded1d1eb779ce6ca1
2010-10-19 23:01:28koweysetstatus: followup-in-progress -> needs-review
2010-11-02 22:31:32ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg12879
2010-11-21 12:12:09darcswatchsetstatus: accepted-pending-tests -> accepted
messages: + msg13133
2011-05-10 20:06:28darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-0d527fb1e923b5462f1c78eded1d1eb779ce6ca1 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-7feb05c1714ed2f8f400e00c9cad14db8415dc0e
2011-05-10 21:06:07darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-7feb05c1714ed2f8f400e00c9cad14db8415dc0e -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-c11705c2d78ff7294fa98837066f3941dccb4dc2
2011-05-10 21:35:37darcswatchsetmessages: + msg14328