Patch 404: resolve issue1951: refuse to add files outside repository - Darcs bug tracker

Title	resolve issue1951: refuse to add files outside repository
Superseder		Nosy List	tux_rocker
Related Issues
Status	accepted	Assigned To
Milestone

Created on 2010-09-26.18:14:20 by tux_rocker, last changed 2011-05-10.18:06:27 by darcswatch. Tracked on DarcsWatch.

Files
File name	Status	Uploaded	Type	Edit	Remove
issue1951-fixannotate.dpatch		tux_rocker, 2010-10-02.19:47:52	text/plain
issue1951.dpatch		tux_rocker, 2010-09-26.18:14:19	text/plain

See mailing list archives for discussion on individual patches.

Messages
msg12612 (view)	Author: tux_rocker	Date: 2010-09-26.18:14:20
This fixes issue1951, one of the 2.5 release blockers. Attachments issue1951.dpatch
msg12613 (view)	Author: tux_rocker	Date: 2010-09-26.18:23:36
Op zondag 26 september 2010 20:14 schreef je: > New submission from Reinier Lamers <tux_rocker@reinier.de>: > > This fixes issue1951, one of the 2.5 release blockers. I forgot to test the effect on other commands than add before I submitted this. 'darcs annotate' now gives you a pattern match failure if you use it on a file outside the repository. 'darcs move GNUmakefile ../GNUmakefile' now says "darcs: Cannot rename a file or directory onto itself!". The other commands that use fixSubPaths look okay. Reinier
msg12627 (view)	Author: tux_rocker	Date: 2010-10-02.19:47:53
Here is a new version of the patch that fixes the pattern match failure in annotate and adds haddock to fixSubPaths. As for the unclear error message with 'darcs move', I suggest not fixing it for 2.5. The error is already present in older darcsen if you use absolute repository paths (like 'darcs move GNUmakefile /var/lib') so it's not a regression. (The pattern match failure in annotate was also not a regression, but it looks bad enough to fix it immediately) Attachments issue1951-fixannotate.dpatch
msg12678 (view)	Author: darcswatch	Date: 2010-10-09.16:55:01
This patch bundle (with 7 patches) was just applied to the repository http://darcs.net/. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-88fd8b30f4c5e9ceb5b497c9d6fffeb11b6fe676
msg14088 (view)	Author: darcswatch	Date: 2011-05-10.18:05:55
This patch bundle (with 5 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-b099a63ff2a2f32a0b0ca644edfa7c0fb9b4ecd8
msg14099 (view)	Author: darcswatch	Date: 2011-05-10.18:06:27
This patch bundle (with 7 patches) was just applied to the repository http://darcs.net/reviewed. This message was brought to you by DarcsWatch http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-88fd8b30f4c5e9ceb5b497c9d6fffeb11b6fe676

History
Date	User	Action	Args
2010-09-26 18:14:20	tux_rocker	create
2010-09-26 18:15:47	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-b099a63ff2a2f32a0b0ca644edfa7c0fb9b4ecd8
2010-09-26 18:23:36	tux_rocker	set	messages: + msg12613
2010-10-02 19:47:54	tux_rocker	set	files: + issue1951-fixannotate.dpatch messages: + msg12627
2010-10-02 19:48:49	darcswatch	set	darcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-b099a63ff2a2f32a0b0ca644edfa7c0fb9b4ecd8 -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-88fd8b30f4c5e9ceb5b497c9d6fffeb11b6fe676
2010-10-05 20:55:28	ganesh	set	status: needs-screening -> needs-review
2010-10-09 15:14:30	ganesh	set	status: needs-review -> accepted-pending-tests
2010-10-09 16:55:01	darcswatch	set	status: accepted-pending-tests -> accepted messages: + msg12678
2011-05-10 18:05:55	darcswatch	set	messages: + msg14088
2011-05-10 18:06:27	darcswatch	set	messages: + msg14099