darcs

Patch 423 Test for issue1978 (and 1 more)

Title Test for issue1978 (and 1 more)
Superseder Nosy List galbolle
Related Issues
Status accepted Assigned To
Milestone

Created on 2010-10-17.13:42:06 by galbolle, last changed 2011-05-10.20:35:35 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
test-for-issue1978.dpatch galbolle, 2010-10-17.13:42:06 text/x-darcs-patch
unnamed galbolle, 2010-10-17.13:42:06
See mailing list archives for discussion on individual patches.
Messages
msg12752 (view) Author: galbolle Date: 2010-10-17.13:42:06
2 patches for repository http://darcs.net/screened:

Sun Oct 17 15:33:04 CEST 2010  Florent Becker <florent.becker@ens-lyon.org>
  * Test for issue1978

Sun Oct 17 15:34:18 CEST 2010  Florent Becker <florent.becker@ens-lyon.org>
  * more thorough checks of _darcs/format handling
Attachments
msg12753 (view) Author: darcswatch Date: 2010-10-17.13:49:33
This patch bundle (with 2 patches) was just applied to the repository http://darcs.net/screened.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_screened.html#bundle-457d1b12345df39dd6f1d85a2d0dce56349a9094
msg13309 (view) Author: kowey Date: 2010-12-10.16:48:57
On Sun, Oct 17, 2010 at 13:42:06 +0000, Florent Becker wrote:
> Sun Oct 17 15:33:04 CEST 2010  Florent Becker <florent.becker@ens-lyon.org>
>   * Test for issue1978
> 
> Sun Oct 17 15:34:18 CEST 2010  Florent Becker <florent.becker@ens-lyon.org>
>   * more thorough checks of _darcs/format handling

I'm applying these with some minor suggestions for future tests

Test for issue1978
------------------
> +darcs get future temp1
> +cd temp1

We could perhaps check the format of the temp1 repo,
make sure it's sane.

> +rm -rf temp1 future

We don't need to do this sort of cleanup anymore.
New harness.


more thorough checks of _darcs/format handling
----------------------------------------------
> - -rm -rf temp1 temp2
> - -mkdir temp1
> - -cd temp1
> +rm -rf garbage future

We don't really need this cleanup anymore

[snip setup]

garbage:
  gobbledygook
future:
  hashed|gobbledygook
  darcs-2

> +# check the rules for reading and writing
> +# pull from garbage repo
> +# apply in garbage repo

> +# add in garbage repo
> +cd garbage
> +touch toto
> +not darcs add toto 2> log
>  grep -i "can't understand repository format" log
> hunk ./tests/repoformat.sh 60
> - -rm -rf temp1 temp2 log
> +cd ..

Hmm, any reason why add in particular?

> +## future repo: we don't understand one
> +#  alternative of a line of format

> +# get future repo: ok
> +# --to-match is needed because of bug###

Could be good to reference the bug number here for future reference

> +darcs get future temp1 --to-match "name titi"
> +cd temp1
> +darcs changes
> +touch toto
> +darcs add toto
> +darcs record -am 'blah'
> +cd ..
> +rm -rf temp1

Same suggestion for sanity checking format check maybe

> +# pull from future repo: ok
> +mkdir temp1
> +cd temp1
> +darcs init
> +darcs pull ../future -a
> +darcs cha | grep titi
> +cd ..
> +rm -rf temp1
> +
> +# apply in future repo: !ok
> +mkdir temp1
> +cd temp1
> +darcs init
> +darcs changes --context > empty-context
> +darcs tag -m "just a patch"
> +darcs send -a --context=empty-context -o ../bundle.dpatch .
> +cd ../future
> +not darcs apply ../bundle.dpatch 2> log
> +cat log
> +grep -i "can't write repository format" log
> +cd ..
> +rm -rf temp1 bundle.dpatch
> +
> +# record in future repo: !ok
> +cd future
> +touch toto
> +not darcs add toto 2> log
> +grep -i "can't write repository format" log
> +cd ..

Looks good

> +rm -rf future #No future!

Heh :-)

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
For a faster response, try +44 (0)1273 64 2905 or
xmpp:kowey@jabber.fr (Jabber or Google Talk only)
msg13367 (view) Author: darcswatch Date: 2010-12-16.17:09:31
This patch bundle (with 2 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-457d1b12345df39dd6f1d85a2d0dce56349a9094
msg14268 (view) Author: darcswatch Date: 2011-05-10.20:35:35
This patch bundle (with 2 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-457d1b12345df39dd6f1d85a2d0dce56349a9094
History
Date User Action Args
2010-10-17 13:42:06galbollecreate
2010-10-17 13:43:09darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-457d1b12345df39dd6f1d85a2d0dce56349a9094
2010-10-17 13:49:33darcswatchsetstatus: needs-screening -> needs-review
messages: + msg12753
2010-12-10 16:48:58koweysetmessages: + msg13309
2010-12-10 16:49:13koweysetstatus: needs-review -> accepted-pending-tests
2010-12-16 17:09:31darcswatchsetstatus: accepted-pending-tests -> accepted
messages: + msg13367
2011-05-10 20:35:35darcswatchsetmessages: + msg14268