1 patch for repository http://darcs.net/screened:

Thu Oct 21 17:45:10 CEST 2010  Florent Becker <florent.becker@ens-lyon.org>
  * convert.sh should not be reserved to subjects of Her Majesty

Attachments

• convert_sh-should-not-be-reserved-to-subjects-of-her-majesty.dpatch
• unnamed

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/screened.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_screened.html#bundle-dc8047705cde9bc8a43ba672867bc4e662975341

On Thu, 21 Oct 2010, Florent Becker wrote:

>
> New submission from Florent Becker <florent.becker@ens-lyon.org>:
>
> 1 patch for repository http://darcs.net/screened:
>
> Thu Oct 21 17:45:10 CEST 2010  Florent Becker <florent.becker@ens-lyon.org>
>  * convert.sh should not be reserved to subjects of Her Majesty

What does darcs produce for you? I'd have expected it to use the metadata 
from the patches - or does convert mess that up somehow?

Ganesh

Le 21/10/2010 21:16, Ganesh Sittampalam a écrit :
> 
> On Thu, 21 Oct 2010, Florent Becker wrote:
> 
>>
>> New submission from Florent Becker <florent.becker@ens-lyon.org>:
>>
>> 1 patch for repository http://darcs.net/screened:
>>
>> Thu Oct 21 17:45:10 CEST 2010  Florent Becker
>> <florent.becker@ens-lyon.org>
>>  * convert.sh should not be reserved to subjects of Her Majesty
> 
> What does darcs produce for you? I'd have expected it to use the
> metadata from the patches - or does convert mess that up somehow?
> 
> Ganesh
> 
The metadata for the recorded (as opposed to .dpatch-applied) patch are
in whatever timezone the user is in. So diff complains that
12:34:56 BST and
13:34:56 EST
are different. One side effect of convert is that all dates in patches
get their dates rewritten in the time-zone of the converter. I think
it's largely ok, so i've changed the test to ignore that. The cleanest
way would be to make all times UTC, but I haven't found an easy way to
do that.

Florent

Florent Becker wrote:
> Le 21/10/2010 21:16, Ganesh Sittampalam a écrit :
>> 
>> On Thu, 21 Oct 2010, Florent Becker wrote:
>> 
>>> 
>>> New submission from Florent Becker <florent.becker@ens-lyon.org>:
>>> 
>>> 1 patch for repository http://darcs.net/screened:
>>> 
>>> Thu Oct 21 17:45:10 CEST 2010  Florent Becker
>>> <florent.becker@ens-lyon.org>
>>>  * convert.sh should not be reserved to subjects of Her Majesty
>> 
>> What does darcs produce for you? I'd have expected it to use the
>> metadata from the patches - or does convert mess that up somehow?
>> 
>> Ganesh
>> 
> The metadata for the recorded (as opposed to .dpatch-applied) patch
> are in whatever timezone the user is in. So diff complains that
> 12:34:56 BST and 13:34:56 EST
> are different. One side effect of convert is that all dates in
> patches get their dates rewritten in the time-zone of the converter.
> I think it's largely ok, so i've changed the test to ignore that. The
> cleanest way would be to make all times UTC, but I haven't found an
> easy way to do that.

Actually, I would call this a bug in convert; it's destroying information without good cause. For now your fix to the test makes sense, though. Luckily we won't need it on the all tests that compare darcs send output.

Ganesh

=============================================================================== 
Please access the attached hyperlink for an important electronic communications disclaimer: 
http://www.credit-suisse.com/legal/en/disclaimer_email_ib.html 
===============================================================================

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi Ganesh
>>>
>> The metadata for the recorded (as opposed to .dpatch-applied) patch
                        ^----s/recorded/converted/
>> are in whatever timezone the user is in. So diff complains that
>> 12:34:56 BST and 13:34:56 EST
>> are different. One side effect of convert is that all dates in
>> patches get their dates rewritten in the time-zone of the converter.
>> I think it's largely ok, so i've changed the test to ignore that. The
>> cleanest way would be to make all times UTC, but I haven't found an
>> easy way to do that.
> 
> Actually, I would call this a bug in convert; it's destroying information
> without good cause. For now your fix to the test makes sense, though.
> Luckily we won't need it on the all tests that compare darcs send output.
> 
Maybe I got the timezone conversion wrong, but it's not actually
destroying information, just presenting it differently (the date of the
patch is not changed, just the way it is stored). I don't see where the
"timezone where the patch was recorded" bit is actually used, so I don't
see any information we're actually destroying. Note that apply -> send
is also not a round-trip if you care about that point, but let's not
bikeshed about that.

Florent
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iEYEARECAAYFAkzBVq8ACgkQTCPcDztjGo61NwCfe9MQK+Fezc8c3QTEdiYC8wRz
GWUAoJaj5DPEhpH5YnVhyqiMcGhC2TYB
=frab
-----END PGP SIGNATURE-----

Florent Becker wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Hi Ganesh
>>>> 
>>> The metadata for the recorded (as opposed to .dpatch-applied) patch
>                         ^----s/recorded/converted/
>>> are in whatever timezone the user is in. So diff complains that
>>> 12:34:56 BST and 13:34:56 EST are different. One side effect of
>>> convert is that all dates in patches get their dates rewritten in
>>> the time-zone of the converter. I think it's largely ok, so i've
>>> changed the test to ignore that. The cleanest way would be to make
>>> all times UTC, but I haven't found an easy way to do that.
>> 
>> Actually, I would call this a bug in convert; it's destroying
>> information without good cause. For now your fix to the test makes
>> sense, though. Luckily we won't need it on the all tests that
>> compare darcs send output. 
>> 
> Maybe I got the timezone conversion wrong, but it's not actually
> destroying information, just presenting it differently (the date of
> the patch is not changed, just the way it is stored). I don't see
> where the "timezone where the patch was recorded" bit is actually
> used, so I don't see any information we're actually destroying. Note
> that apply -> send is also not a round-trip if you care about that
> point, but let's not bikeshed about that.      

Oh, I see. I misunderstood completely; the patches are always stored in
a repo with the same time and convert preserves that, but send formats
it according to the local time when providing the human-readable text at
the top. That's fine, but it does also mean that the other tests I
recently added are broken too, I'll fix them later.

Ganesh

This is fine, once patch420 is accepted.

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-dc8047705cde9bc8a43ba672867bc4e662975341

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-dc8047705cde9bc8a43ba672867bc4e662975341