Hi,

this is another attempt to solve issue332, thanks to an idea of Peter
Rockai.

It removes calls to testTentative from finalizeRepositoryChanges and
changes testTentative and testRecorded to return the exit code of the
test.

Each command which accepts the --test (or --no-test) flag is now
responsible for running the test.  When run in interactive mode, if the
test fails, these commands ask the user to confirm the abort.  When run
in non-interactive mode, the old behaviour is kept.

This patch also contains a fix to the darcs testsuite to handle the new
confirmation.

Calls to finalizeRepositoryChanges in Repository.hs (more precisely
those performed by copyPackedRepository and copyNotPackedRepository)
have not been modified because I believe no test is ever run when a full
copy of repository is done.  The same goes for commands like optimize,
etc.

Best,
Gabriel

1 patch for repository http://darcs.net:

Sun Nov  7 20:19:55 CET 2010  Gabriel Kerneis <kerneis@pps.jussieu.fr>
  * resolve issue332: ask if test fails

Attachments

• resolve-issue332_-ask-if-test-fails.dpatch
• unnamed

Duplicate of patch454 (sent twice).