darcs

Patch 465 document showContextPatch

Title document showContextPatch
Superseder Nosy List galbolle
Related Issues
Status accepted Assigned To
Milestone

Created on 2010-11-16.14:16:56 by galbolle, last changed 2011-05-10.22:35:53 by darcswatch. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
correct-showcontextpatch-documentation.dpatch galbolle, 2010-11-17.19:58:05 text/x-darcs-patch
document-showcontextpatch.dpatch galbolle, 2010-11-16.14:16:56 text/x-darcs-patch
unnamed galbolle, 2010-11-16.14:16:56
unnamed galbolle, 2010-11-17.19:58:05
See mailing list archives for discussion on individual patches.
Messages
msg13078 (view) Author: galbolle Date: 2010-11-16.14:16:56
1 patch for repository http://darcs.net/screened:

Fri Nov 12 09:55:23 CET 2010  Florent Becker <florent.becker@ens-lyon.org>
  * document showContextPatch
Attachments
msg13079 (view) Author: darcswatch Date: 2010-11-16.14:31:25
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/screened.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_screened.html#bundle-3fff01725e29b5b21a2a8e056dfe54a12b9d4a5c
msg13082 (view) Author: mornfall Date: 2010-11-16.21:28:23
Hi,

Florent Becker <bugs@darcs.net> writes:

>      showPatch :: p C(x y) -> Doc
>      showNicely :: p C(x y) -> Doc
>      showNicely = showPatch
> +    -- | showContextPatch is used to add context to a patch,
> +    -- for instance before putting it into a bundle. As context
> +    -- is not included in patch representation, this requires access
> +    -- to the pristine (?) tree.
This is confusing -- context in darcs normally means [PatchInfo] kind of
context, especially when you talk about bundles. Until I got to the part
about pristine (which is wrong) I believed you were talking about that
kind of context. About the tree it needs, that is the tree that
corresponds to the (darcs) context of the patch: if the patch =
unrecorded, it is indeed the pristine, but in other cases it is not
(especially it is not the pristine in the bundle generation case).

>      showContextPatch :: p C(x y) -> TreeIO Doc
>      showContextPatch p = return $ showPatch p
>      description :: p C(x y) -> Doc

Petr.
msg13097 (view) Author: galbolle Date: 2010-11-17.19:58:05
1 patch for repository http://darcs.net/screened:

Wed Nov 17 20:49:27 CET 2010  Florent Becker <florent.becker@ens-lyon.org>
  * correct showContextPatch documentation
Attachments
msg13099 (view) Author: darcswatch Date: 2010-11-17.20:11:27
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/screened.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_screened.html#bundle-64171ed344f680d3c48b99a366d2f79dd81da7e1
msg13145 (view) Author: ganesh Date: 2010-11-21.14:08:06
Looks fine now.
msg13149 (view) Author: darcswatch Date: 2010-11-21.14:51:40
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-64171ed344f680d3c48b99a366d2f79dd81da7e1
msg13151 (view) Author: darcswatch Date: 2010-11-21.14:51:48
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-3fff01725e29b5b21a2a8e056dfe54a12b9d4a5c
msg14113 (view) Author: darcswatch Date: 2011-05-10.18:35:49
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-64171ed344f680d3c48b99a366d2f79dd81da7e1
msg14420 (view) Author: darcswatch Date: 2011-05-10.22:35:53
This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-3fff01725e29b5b21a2a8e056dfe54a12b9d4a5c
History
Date User Action Args
2010-11-16 14:16:56galbollecreate
2010-11-16 14:31:25darcswatchsetstatus: needs-screening -> needs-review
messages: + msg13079
2010-11-16 14:34:58darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-3fff01725e29b5b21a2a8e056dfe54a12b9d4a5c
2010-11-16 21:28:24mornfallsetmessages: + msg13082
2010-11-17 19:58:06galbollesetfiles: + correct-showcontextpatch-documentation.dpatch, unnamed
messages: + msg13097
2010-11-17 19:59:28darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-3fff01725e29b5b21a2a8e056dfe54a12b9d4a5c -> http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-64171ed344f680d3c48b99a366d2f79dd81da7e1
2010-11-17 20:11:27darcswatchsetmessages: + msg13099
2010-11-21 14:08:06ganeshsetstatus: needs-review -> accepted-pending-tests
messages: + msg13145
2010-11-21 14:51:40darcswatchsetstatus: accepted-pending-tests -> accepted
messages: + msg13149
2010-11-21 14:51:48darcswatchsetmessages: + msg13151
2011-05-10 18:35:49darcswatchsetmessages: + msg14113
2011-05-10 22:35:53darcswatchsetmessages: + msg14420