Hey,

this is needed to get darcs building on windows again. A dead code cleanup
patch earlier cleaned up a bit too much. Please fast-track review if at all
possible, it's both trivial and it partially unbreaks buildbot on windows
(still there's a test failing).

A related challenge: (I already mentioned that on IRC, but I guess it's worth
repeating): If you can make the (current) buildbot go green, I'll set up a
windows 7 slave, and maybe also install GHC 7 on some of the existing slaves to
get that covered, too.

Yours,
   Petr.

1 patch for repository http://darcs.net/screened:

Thu Nov 18 17:45:45 CET 2010  Petr Rockai <me@mornfall.net>
  * Put back showHexLen into Darcs.Utils, it's needed on windows.

Attachments

• put-back-showhexlen-into-darcs_utils_-it_s-needed-on-windows_.dpatch
• unnamed

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/screened.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_screened.html#bundle-08922373581a7fa87f72c9a5e99aa3e9eb46258e

On Thu, Nov 18, 2010 at 17:55:43 +0000, Petr Ročkai wrote:
> this is needed to get darcs building on windows again. A dead code cleanup
> patch earlier cleaned up a bit too much. Please fast-track review if at all
> possible, it's both trivial and it partially unbreaks buildbot on windows
> (still there's a test failing).

Fast tracked accordingly.
Nothing to review as its old code and not being used in a new way.

PS. still mostly ignoring patches
    post-holiday act only 60% together, more progress to go

Put back showHexLen into Darcs.Utils, it's needed on windows.
-------------------------------------------------------------
> Petr Rockai <me@mornfall.net>**20101118164545
>  Ignore-this: 7e5fc87887c2b3fae0a99b2846652068
> ] hunk ./src/Darcs/Utils.hs 71
>  import qualified Storage.Hashed.Monad as HS ( exists, tree )
>  import Storage.Hashed.Tree( Tree, listImmediate, findTree )
>  
> +showHexLen :: (Integral a) => Int -> a -> String
> +showHexLen n x = let s = showHex x ""
> +                 in replicate (n - length s) ' ' ++ s
  
> hunk ./src/Darcs/Utils.hs 39
>  import System.IO.Error ( annotateIOError, isUserError, ioeGetErrorString )
>  
>  import Darcs.SignalHandler ( catchNonSignal )
> +import Numeric ( showHex )
>  import System.Directory ( doesFileExist )
>  import System.Exit ( ExitCode(..) )
>  import System.Environment ( getEnv )
> hunk ./src/Darcs/Utils.hs 6
>  {-# LANGUAGE CPP, ForeignFunctionInterface #-}
>  
>  module Darcs.Utils ( ortryrunning, nubsort, breakCommand
> +                   , showHexLen

-- 
Eric Kow <http://www.nltg.brighton.ac.uk/home/Eric.Kow>
For a faster response, try +44 (0)1273 64 2905 or
xmpp:kowey@jabber.fr (Jabber or Google Talk only)

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-08922373581a7fa87f72c9a5e99aa3e9eb46258e

This patch bundle (with 1 patches) was just applied to the repository http://darcs.net/reviewed.
This message was brought to you by DarcsWatch
http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-08922373581a7fa87f72c9a5e99aa3e9eb46258e