darcs

Patch 494 darcsdir ++ "/pristine.hashed" -> hashed... (and 1 more)

Title darcsdir ++ "/pristine.hashed" -> hashed... (and 1 more)
Superseder Nosy List dmitry.tsygankov
Related Issues
Status rejected Assigned To dmitry.tsygankov
Milestone

Created on 2010-11-29.23:03:38 by dmitry.tsygankov, last changed 2012-01-01.22:56:33 by kowey. Tracked on DarcsWatch.

Files
File name Status Uploaded Type Edit Remove
darcsdir-__-__pristine_hashed_-__-hashedpristinedirectory.dpatch dmitry.tsygankov, 2010-11-29.23:03:37 text/x-darcs-patch
unnamed dmitry.tsygankov, 2010-11-29.23:03:37
See mailing list archives for discussion on individual patches.
Messages
msg13270 (view) Author: dmitry.tsygankov Date: 2010-11-29.23:03:37
2 patches for repository http://darcs.net:

Tue Nov 30 00:28:14 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * darcsdir ++ "/pristine.hashed" -> hashedPristineDirectory

Tue Nov 30 01:46:07 MSK 2010  Dmitry Tsygankov <dmitry.tsygankov@gmail.com>
  * "_darcs" -> darcsdir
Attachments
msg13522 (view) Author: galbolle Date: 2011-01-19.15:42:15
darcsdir ++ "/pristine.hashed" -> hashedPristineDirectory
---------------------------------------------------------
Dmitry Tsygankov <dmitry.tsygankov@gmail.com>**20101129212814

ok

"_darcs" -> darcsdir
--------------------
Dmitry Tsygankov <dmitry.tsygankov@gmail.com>**20101129224607

ok, though it's a bit alarming to have darcsdir ++ "/blah" vs darcsdir
</> "blah" all over. On the other hand, this patch is not making it
any worse.
msg13523 (view) Author: galbolle Date: 2011-01-19.15:50:11
This now conflicts with screened.
msg13534 (view) Author: kowey Date: 2011-01-20.15:29:22
Sorry for the holdup in reviewing your cleanup work, Dmitry.  Let us know 
if there's anything we can do to help you resubmit (this time against 
http://darcs.net/screened if it that's OK).  Thanks!
msg13542 (view) Author: dmitry.tsygankov Date: 2011-01-20.16:54:00
> it's a bit alarming to have darcsdir ++ "/blah" vs darcsdir </> "blah"
all over

Exactly, that's what I thought. The only reason why I didn't fix this
immediately was that, in fact, there are three possible separator
choices here: "/", System.FilePath.(</>) and 
System.FilePath.Posix.(</>), and I'm not sure if System.FilePath.(</>)
would break Darcs on Windows, by creating URLs like
"http://www.darcs.net\_darcs\". Some kind of 'official' coding
convention would be useful.

> Let us know if there's anything we can do to help you resubmit

Thanks, I'm fine with that, though it would have to wait until February.
There's surely no need to waste your precious time resolving these
conflicts.
msg14947 (view) Author: kowey Date: 2012-01-01.22:56:33
I think we should just drop this patch (sorry, Dmitry)

It's worth doing, but a bit tedious.  Somebody else (hopefully Dmitry) in 
the future will hopefully get sick enough of the strings to fix it again.
History
Date User Action Args
2010-11-29 23:03:38dmitry.tsygankovcreate
2010-12-16 17:09:19darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-8328a4ac164410162d52505bf112f4a51d29ea5f
2011-01-19 15:42:15galbollesetstatus: needs-review -> accepted
messages: + msg13522
2011-01-19 15:50:11galbollesetstatus: accepted -> followup-requested
assignedto: dmitry.tsygankov
messages: + msg13523
2011-01-20 15:29:22koweysetmessages: + msg13534
2011-01-20 16:54:00dmitry.tsygankovsetmessages: + msg13542
2011-05-10 19:36:24darcswatchsetdarcswatchurl: http://darcswatch.nomeata.de/repo_http:__darcs.net_.html#bundle-8328a4ac164410162d52505bf112f4a51d29ea5f -> http://darcswatch.nomeata.de/repo_http:__darcs.net_reviewed.html#bundle-8328a4ac164410162d52505bf112f4a51d29ea5f
2012-01-01 22:56:33koweysetstatus: followup-requested -> rejected
messages: + msg14947